C++ library for ST Teseo GPS - pt. 3: Pico and UART support

RE: C++ library for ST Teseo GPS - pt. 3: Pico and UART support

DAB — Sat, 20 Jul 2024 18:06:09 GMT

Nice update Jan.

RE: C++ library for ST Teseo GPS - pt. 3: Pico and UART support

Jan Cumps — Fri, 19 Jul 2024 21:54:26 GMT

If I'd code review my own code, I'd challenge having pBuf (a pointer into the read buffer) public global.

I'd challenge myself to have it interrupt local (as a static).
And make it reset itself to the start of the buffer before starting a new read.

One option would be to replace the Boolean guard:

volatile bool bWantChars;

by an enumerator with 3 states: start - doing - done ...

RE: C++ library for ST Teseo GPS - pt. 3: Pico and UART support

shabaz — Fri, 19 Jul 2024 20:19:35 GMT

Nice work. This will make it far easier to use the module. I think this is the first time I'm seeing STL pair being used, very interesting. Neat how the command response verification string becomes simply part of a pair with the command request!