Port an MBED design to non-MBED - Phase 1: compile without errors

RE: Port an MBED design to non-MBED - Phase 1: compile without errors

Jan Cumps — Mon, 11 Nov 2019 17:14:01 GMT

Some further progress

The non-working project now compiles with 3 warnings left:

[View:/resized-image/__size/546x173/__key/commentfiles/f7d226abd59f475c9d224a79e3f0ec07-a400c0b4-5282-4e47-b5cf-7ca77962ae97/contentimage_5F00_192874.png:546:173]

The first one I have to look into. I'm using the correct linker file for my controller but one source somewhere seems to have a sections pragma.

The 2 others are to be ignored, because they are a result of me commenting out code dependencies for things I have to write.

Here are the to-dos to get the cycle closed:

[embed:dc8ab71f-3b98-42d9-b0f6-e21e02a0f8e2:3ef06e6b-9b7d-4651-b12d-db8be7f5e991:type=text&text=TODO+DigitalIn.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+11+C%2FC%2B%2B+Task%0ATODO+DigitalInOut.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+11+C%2FC%2B%2B+Task%0ATODO+DigitalInOut.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+15+C%2FC%2B%2B+Task%0ATODO+DigitalInOut.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+22+C%2FC%2B%2B+Task%0ATODO+DigitalInOut.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+27+C%2FC%2B%2B+Task%0ATODO+DigitalInOut.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+33+C%2FC%2B%2B+Task%0ATODO+DigitalInOut.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+38+C%2FC%2B%2B+Task%0ATODO+DigitalOut.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+11+C%2FC%2B%2B+Task%0ATODO+DigitalOut.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+18+C%2FC%2B%2B+Task%0ATODO+DigitalOut.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+25+C%2FC%2B%2B+Task%0ATODO+InterruptIn.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+11+C%2FC%2B%2B+Task%0ATODO+SPI.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+11+C%2FC%2B%2B+Task%0ATODO+SPI.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+15+C%2FC%2B%2B+Task%0ATODO+SPI.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+20+C%2FC%2B%2B+Task%0ATODO+SPI.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+24+C%2FC%2B%2B+Task%0ATODO+%3D+fix+this-%3EdioIrq%5B5%5D+%3D+NULL%3B+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+68+C%2FC%2B%2B+Task%0ATODO+Auto-generated+constructor+stub+SemTechSx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp+line+126+C%2FC%2B%2B+Task%0ATODO+Auto-generated+constructor+stub+Timeout.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+11+C%2FC%2B%2B+Task%0ATODO+Auto-generated+destructor+stub+SemTechSx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp+line+131+C%2FC%2B%2B+Task%0ATODO+Auto-generated+destructor+stub+Timeout.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fimplementation_dependent%2Fclient_platform+line+16+C%2FC%2B%2B+Task%0ATODO+fix+tmath+dependencies+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+528+C%2FC%2B%2B+Task%0ATODO+fix+tmath+dependencies+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+578+C%2FC%2B%2B+Task%0ATODO+fix+tmath+dependencies+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+829+C%2FC%2B%2B+Task%0ATODO+fix%2Fport+++++++++++++if%28+this-%3EdioIrq%5B4%5D+%3D%3D+NULL+%29+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+1469+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+1+%29%3B+sx1276-hal.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+95+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+1+%29%3B+sx1276-hal.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+105+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+1+%29%3B+sx1276-hal.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+304+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+1+%29%3B+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+108+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+1+%29%3B+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+147+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+1+%29%3B+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+665+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+10+%29%3B+SemTechSx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp+line+228+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+10+%29%3B+SemTechSx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp+line+243+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+10+%29%3B+SemTechSx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp+line+268+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+10+%29%3B+SemTechSx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp+line+302+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+10+%29%3B+SemTechSx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp+line+321+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+10+%29%3B+SemTechSx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp+line+332+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+10+%29%3B+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+56+C%2FC%2B%2B+Task%0ATODO+implement+wait_ms%28+6+%29%3B+sx1276-hal.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+306+C%2FC%2B%2B+Task%0ATODO+implement+wait%28+1+%29%3B+SemTechSx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp+line+158+C%2FC%2B%2B+Task%0ATODO+implement+wait%280.1%29%3B+sx1276-hal.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+140+C%2FC%2B%2B+Task%0ATODO+port+SX1276MB1xAS+Radio%28+NULL+%29%3B+SemTechSx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp+line+104+C%2FC%2B%2B+Task%0ATODO+port+this.+It+was+too+complex+to+just+move+to+missing.h+sx1276-hal.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+153+C%2FC%2B%2B+Task%0ATODO+port+this.+It+was+too+complex+to+just+move+to+missing.h+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+925+C%2FC%2B%2B+Task%0ATODO+port+this.+It+was+too+complex+to+just+move+to+missing.h+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+980+C%2FC%2B%2B+Task%0ATODO+port+this.+It+was+too+complex+to+just+move+to+missing.h+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+1121+C%2FC%2B%2B+Task%0ATODO+port+this.+It+was+too+complex+to+just+move+to+missing.h+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+1209+C%2FC%2B%2B+Task%0ATODO+port+this.+It+was+too+complex+to+just+move+to+missing.h+sx1276.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+1259+C%2FC%2B%2B+Task%0ATODO+set+for+client+board+sx1276-hal.cpp+%2FTMS570LC43_semtech_sx1276_cpp%2Fcpp%2Fsx1276%2Fsx1276+line+137+C%2FC%2B%2B+Task]

A lot of work but many are repeats.

1 to 15 and 48 are code I need to write.
17 to 20 are empty constructors and destructors. Some need work, some can stay empty
21 to 23 are a little harder to resolve because I may have stumbled on a know error of my compiler. I may have to provide an own implementation for 3 tmath functions.
25 to 40 can be fixed in a single throw. Just need to write 2 functions that implement wait() and wait_ms() for the target controller
42 to 47 are the callback mechanism for interrupts. Todo.
16 and 41: random activities

RE: Port an MBED design to non-MBED - Phase 1: compile without errors

shabaz — Sun, 10 Nov 2019 20:34:21 GMT

Hi Jan,

This is really great progress. This will be extremely useful to anyone who wishes to work with LoRa!

Regarding interrupt handling, if you're trying to make it cross-platform to work without an OS too, I'm sure you have your favourite methods to do it, for what it's worth for hobby stuff I sometimes I just have a timer tick always running (say every millisecond or ten millisec), and execute my state machine in there (since that doesn't take much overhead and executes quickly). Then, any messages to the state machine just become the setting of variables, and similarly any code that needs to be executed by the state machine is another variable change.. and a main while forever loop handles each message at a time. This is super-basic and full of holes if not done carefully, but at least is supported everywhere that a timer tick or periodic function works, and doesn't need threads either, nor C++. On larger systems there's the luxury of using actual real-time middleware of course, but that turns it all into a more major project.

RE: Port an MBED design to non-MBED - Phase 1: compile without errors

Jan Cumps — Sun, 10 Nov 2019 20:15:08 GMT

... next steps are to solve those parts that are not strictly MBED dependencies, but C++ dependencies that are resolved somewhere in th MBED includes.

I have these instances:

memory copy and I/O (not gpio) functions

ceil, floor and rint templates.

The memory copy functions are declared in the following headers

[embed:dc8ab71f-3b98-42d9-b0f6-e21e02a0f8e2:3ef06e6b-9b7d-4651-b12d-db8be7f5e991:type=c_cpp&text=%23include+%3Cstdio.h%3E%0A%23include+%3Cstring.h%3E]

ceil, floor and rint in this one:

[embed:dc8ab71f-3b98-42d9-b0f6-e21e02a0f8e2:3ef06e6b-9b7d-4651-b12d-db8be7f5e991:type=c_cpp&text=%23include+%3Ctgmath.h%3E]

I have added a header file called includes.h to my implementation, in the subfolder "client_platform"

[embed:dc8ab71f-3b98-42d9-b0f6-e21e02a0f8e2:3ef06e6b-9b7d-4651-b12d-db8be7f5e991:type=c_cpp&text=%2F*%0A+*+includes.h%0A+*%0A+*++Created+on%3A+10+nov.+2019%0A+*++++++Author%3A+jancu%0A+*%2F%0A%0A%23ifndef+CPP_IMPLEMENTATION_DEPENDENT_CLIENT_PLATFORM_INCLUDES_H_%0A%23define+CPP_IMPLEMENTATION_DEPENDENT_CLIENT_PLATFORM_INCLUDES_H_%0A%0A%23include+%22.%2Fclient_platform%2Fhard_includes.h%22%0A%23include+%3Cstdio.h%3E%0A%23include+%3Cstring.h%3E%0A%0A%2F%2F+for+ceil%2C+floor%2C+rint%3A%0A%23include+%3Ctgmath.h%3E%0A%0A%23endif+%2F*+CPP_IMPLEMENTATION_DEPENDENT_CLIENT_PLATFORM_INCLUDES_H_+*%2F]

this one will have all required standard C++ header includes that are available for MBED programs via the MBED headers.

There's also a specific include:

[embed:dc8ab71f-3b98-42d9-b0f6-e21e02a0f8e2:3ef06e6b-9b7d-4651-b12d-db8be7f5e991:type=c_cpp&text=%23include+%22.%2Fclient_platform%2Fhard_includes.h%22]

That file will not be part of the device independent port.

Any implementer (read: me) will have to provide it, and put device dependent neccesary includes there that are needed to compile the solution.

There will alse be room for a "client_platform" location to put the device dependent implementation code.

The deal is that you'd (I'd) have to adapt only files in the external "client_platform" folder to make the library work for different microcontroller families.

A more advanced way of doing this is by creating abstract classes that would need to be implemented by your personal C++ device dependent classes.

That's for later. No use in abstracting something I don't have working yet.

edit: the goal is that you'd only have to modify files in the external client_platform sources. And that the rest is an as clean as possible port from MBED.

I could make it less-intrusive by calling my header file mbed.h instead of includes.h. In that case non of the MBED dependent sources would need to change. But that would give a signal that the support lib is mbed, while it isn't.

I'd even have to use the mbed namespace in my code, and that's a nono

RE: Port an MBED design to non-MBED - Phase 1: compile without errors

Jan Cumps — Sun, 10 Nov 2019 19:48:33 GMT

The main functionality I'm missing at this point is difital GPIO and SPI and interrupt callbacks.

It should not be too hard to come up with a design for the first two that's close to the MBED design.

The interrupt callback mechanism is based on templates. I understand templates but there's significant reading and reverse engineering to be done for that.

If there's an MBED guru here on the forum that can explain or help abstract out the callback mechanism, that would be welcome (and a time-speed-upper).