Does the runGesture function inside gesture.c make sense to you?

Question

I am reviewing the Firmware Framework code to see where I need to make changes for my own application and I came across this code inside gesture.c which does not make sense to me... 
 void runGesture(int pixels[], GestureResult *gesResult)
{
 // Initialize result structure
 memset(gesResult, 0, sizeof(GestureResult));
 gesResult->state = STATE_INACTIVE;
 gesResult->gesture = GEST_NONE;

 // Noise filter
 if (gestCfg.enable_window_filter) {
 noiseWindow3Filter(pixels, gestCfg.window_filter_alpha, reset_flag);
 }

 // Process pixels for dynamic gesture
 if (1) {
 DynamicGestureResult dynamicResult;
 runDynamicGesture(&gestCfg, pixels, &dynamicResult);
 gesResult->state = dynamicResult.state;
 gesResult->n_sample = dynamicResult.n_sample;
 gesResult->maxpixel = dynamicResult.maxpixel;
 gesResult->x = dynamicResult.x;
 gesResult->y = dynamicResult.y;
 }
 // Process pixels for tracking
 if (0) {
 TrackingResult trackResult;
 runTracking(&gestCfg.trackingConfig, pixels, &trackResult);
 gesResult->state = trackResult.state;
 gesResult->maxpixel = trackResult.maxpixel; // Will override dynamic result if any
 gesResult->x = trackResult.x; // Will override dynamic result if any
 gesResult->y = trackResult.y; // Will override dynamic result if any
 }
}

How do these conditions get met... 
 // Process pixels for dynamic gesture if (1) { ..... } 
 // Process pixels for tracking if (0) { ..... } 
 
 Now wondering what it should read... any idea?

misaz · Accepted Answer

It make sense. I call it macro-less #ifdef. I was also currios about it but later I realized that it is most probably code representation of following mode selector from EVKIT GUI:

If you want to run gesture detecting algorithm than set 1 in first if, if you want to just track movements, then set 1 in second if. Most probably you can safely set 1 to both ifs and then you will be running both algorithms at once. Setting both ifs to zero does not make sense. 
 Also note that this code style indicate that firmware compiled from Firmware Framework is not the same as stock firmware because stock firmware can change this in runtime.

Does the runGesture function inside gesture.c make sense to you?

Top Replies