New to arduino and programming, 4x3 analog keypad question about making a passcode

Hi again. I have rewritten the code to try and sort out my problems. I have stopped the keypad returning conatant zeros but i still cannot get the password to work. Hopefully one of you will be able to help me with that. I can manage the rest of it.

Thank you.

Jeremy

int i, k, pwcount=0;
char password[]="1234",entry[10];// password that is stored
int buttonPin=0;// keypad pin
int val;// value of key pressed
int PIR=12;//PIR sensor power pin
int senseValue;// value of PIR sensor pin
int nos;// variable for number of the keypad
int sensePin=1;//Pin PIR is connected to
int buzzerPin=2;// buzzer connected here

int led3=3;// leds for testing
int led4=4;
int led5=5;
int led=13;

void setup() {
pinMode (buttonPin,INPUT);
pinMode (sensePin,INPUT);
pinMode(PIR,OUTPUT);
pinMode (led,OUTPUT);
pinMode (led3,OUTPUT);
pinMode (led4,OUTPUT);
pinMode (led5,OUTPUT);
pinMode (buzzerPin,OUTPUT);
Serial.begin(9600);

}

void loop() {
   for (i=0; i<=1; i++){
  reset();


  val=analogRead(buttonPin);
  val = map(val, 0, 1023, 0, 255);
// Serial.print("Button Value   ");//used for debugging
//Serial.println(val);


senseValue=analogRead(sensePin);
senseValue = map(senseValue, 0, 1023, 0, 255);
//Serial.print("     Sensor Value   ");
//Serial.println(senseValue);

//delay(200);

if((val>10&&val<17)){(nos=1);//read the keypad
blinker();


  if( nos==1){
   entry[pwcount]='1' ;//returns the button press
   pwcount++;
   delay(250);
Serial.print('1');//prints the key value for debugging

 
}}

if((val>20&&val<29)){(nos=2);
  blinker();
  if( nos==2){
   entry[pwcount]='2' ;
   pwcount++;
   delay(250);
Serial.print('2');

  
}}

if((val>31&&val<38)){(nos=3);
  blinker();


  if( nos==3){
   entry[pwcount]='3' ;
   pwcount++;
   delay(250);
Serial.print('3');


 
 
}}

if((val>50&&val<58)){(nos=4);
  blinker();


  if( nos==4){
   entry[pwcount]='4' ;
   pwcount++;
   delay(250);
Serial.print('4');


 
 
}}

if((val>75&&val<88)){(nos=5);
   blinker();


  if( nos==5){
   entry[pwcount]='5' ;
   pwcount++;
   delay(250);
Serial.print('5');

 
 
 
}}
if((val>101&&val<115)){(nos=6);
  blinker();


  if( nos==6){
   entry[pwcount]='6' ;
   pwcount++;
   delay(250);
Serial.print('6');


 
 
}}
if((val>138&&val<150)){(nos=7);
  blinker();


  if( nos==7){
   entry[pwcount]='7' ;
   pwcount++;
   delay(250);
Serial.print('7');

 
 
 
}}
if((val>170&&val<180)){(nos=8);
  blinker();


  if( nos==8){
   entry[pwcount]='8' ;
   pwcount++;
   delay(250);
Serial.print('8');

 
 
}}
if((val>195&&val<202)){(nos=9);
  blinker();


  if( nos==9){
   entry[pwcount]='9' ;
   pwcount++;
   delay(250);
Serial.print('9');


 
 
}}
if((val>219&&val<226)){(nos=10);
   blinker();


  if( nos==10){
   entry[pwcount]='*' ;
   pwcount++;
   delay(250);
Serial.print('*');

 
 
}}
if((val>230&&val<238)){(nos=11);
  blinker();


  if( nos==11){
   entry[pwcount]='0' ;
   pwcount++;
   delay(250);
Serial.print('0');

 
 
}}
if((val>238&&val<245)){(nos=12);
   blinker();


  if( nos==12){
   entry[pwcount]='#' ;
   pwcount++;
   delay(250);
Serial.print('#');
pwcount=0;
  }
  for(k=0; k<=5; k++){//if the passwords match this part does not work
   if(k==5){
  Serial.println("Alarm Disabled");
   digitalWrite(3, HIGH);
   digitalWrite (4, LOW);
   digitalWrite (13,LOW);
   digitalWrite(PIR,LOW);
  
  
 
   break;
  
  } 

  }
  

   if(password[k] != entry[k]){// if the passwords do not match
     digitalWrite (4, HIGH);
    // Serial.println("Alarm ON 2 Seconds Until Armed");
     digitalWrite(3,LOW);
      break;
     armed();
     //delay(2000);
     //digitalWrite (13,HIGH);
  
     break;
  
  }
  // k<10
  for(k=0; k<10; k++)
  entry[k]=0;
  } 
}
}

void reset(){
   int j;
   for(j=0; j<=1; j++)
   analogWrite(j,LOW);
}

void blinker(){// blinks the led for confirmation of button press
  digitalWrite(13, HIGH);
  delay(15);
  digitalWrite(13, LOW);
 
 
}
void printing(){
delay(200);

}
void armed (){
  delay(100);
  digitalWrite(13,HIGH);
  digitalWrite(PIR,HIGH);
    Serial.println("Alarm Enabled");
     printing();
     Serial.println("Callibrating System Please wait..");
     printing();
     Serial.println("System Activating...");
     printing();
     Serial.println("All Systems Functioning Correctly");
      printing();
       delay(500);
     Serial.println("Alarm On");
}

void triggered(){
  digitalWrite(buzzerPin,HIGH);
  digitalWrite(13,LOW);
  delay(30);
  digitalWrite(buzzerPin,LOW);
  digitalWrite(13,HIGH);
  delay(30);
}

Hi Billabott. I have made the changes as you have shown. The ldr should have been PIR for my motion sensor..( I hve changed that now) I will comment my sketch more to make it easier to read.

The code keeps on looping I think because the keypad returns a constant 0 value from the analog pin. I want to make some code to ignore the value 0 but I cannot make it do that.

Thanks for looking at it for me though

Jeremy

After looking at an official arduino.cc example of using analog input ports, I can safely recommend several changes to your code.

As far as I know, A0 and A1 are just undefined variables and as such are of no value in configuring the analog pins.

char password[]="1234",entry[10];

int buttonPin=0;                  //  here

int val;                              // here            

int ldr=12;        // what the heck is this?  You Need a Whole Lot more comments documenting your intent

int senseValue;                 // here

int led=13;

int sensePin=1;                   //here

Thank you billabott I would appreciate that.

Jeremy

The usual way to handle the sequencing of actions in the code is via a "state machine".  Will have time to look at your code tomorrow unless someone else pipes in.