Requesting help with Strings

Question

I have started a sketch for making a Barometer that logs to a SD Card at fifteen minute intervals. Problem I am having is getting the right formating for dataStrings1, dataString2, and dataString3.

Both the LogFile and Serial.print output a CVS formated line for 1 record.

Global variables:

String dataString1 = (dataString1);

String dataString2 = (dataString2);

String dataString3 = (dataString3);

void setup ()

:

String(dataString1) = "+= String(RTCTimedEvent.time.hour), DEC) + ":" += String(RTCTimedEvent.time.minute, DEC) + ":" += String(RTCTimedEvent.time.second), DEC)";

String(dataString2) = "+= String(RTCTimedEvent.time.month), DEC) + "/" += String(RTCTimedEvent.time.day), DEC) + "/" += String(RTCTimedEvent.time.year), DEC))";

String(dataString3) = "+= String(Pressure, DEC) + ", " += String(atm, DEC) + ", " += String(Altitude, DEC)";

logFile.println"String(id) + ", " + (dataString1) + ", " + (dataString2) + ", " + (dataString3)";

logFile.close();

Serial.println"String(id) + ", " + (dataString1) + ", " + (dataString2) + ", " + (dataString3)";

sketch_dec13a.ino: In function 'void setup()':

sketch_dec13a:135: error: expected ',' or ';' before ':' token

sketch_dec13a:136: error: invalid operands of types 'const char [45]' and 'const char [44]' to binary 'operator/'

sketch_dec13a:137: error: expected unqualified-id before string constant

sketch_dec13a.ino: In function 'void loop()':

sketch_dec13a:166: error: expected `;' before string constant

sketch_dec13a:166: error: statement cannot resolve address of overloaded function

sketch_dec13a:168: error: expected `;' before string constant

sketch_dec13a:168: error: statement cannot resolve address of overloaded function

I have gone from 35 errors to only these error; I could sure use some help wwith these Strings!

There is a new book, that I have on order: "Beginning C for Arduino" by Jack Purdum. Book is due to arrive Saturaday.

Will attach or email sketch if needed.

cookieglitch · Accepted Answer

As with your other thread, your quotation marks are the wrong way around which is producing the first few errors. In relation to the issues on lines 175 and 177, the issue is a mix up between the use of " and ( ). When using functions (Also known as methods), the parameters of the function go inside of the ( and ). If they are fixed values such as a string, they are then wrapped in quotation marks, otherwise they are left alone. So applying this to the line logFile.println"String(id) + ", " + (dataString1) + ", " + (dataString2) + ", " + (dataString3)"; the main function is logFile.println, which is used as logFile.println(parameters here). This means the line of code would be logFile.println(String(id) + ", " + (dataString1) + ", " + (dataString2) + ", " + (dataString3)); Similarly, line 137 would become String dataString1 = String((RTCTimedEvent.time.hour), DEC) + String(":") + 
 String((RTCTimedEvent.time.minute), DEC) + String(":") +
 String((RTCTimedEvent.time.second), DEC); Remember, quotation marks only go around values that are constant and not variables. When errors popup, don't forget to check for errors like this, many compiler errors can be put down to simple typos like this. As coder27 said, the next step would be to start simplifing the program into small pieces you can work on without getting sidetracked by other issues. You could do this by creating a new sketch to test that specific piece of code (Only works in certain situations before it starts getting complicated), or comment out the other errors and fix one at a time. Have a google, there are plenty of debugging tutorials around to get you going when you are ready.