Help with joining two pieces of code.

Thanks Paul & Chris,

Ok so I fused both your suggestions together but now it seems there are syntax errors. I tried moving curly braces and parenthesis around but didnt seem to have much luck.

here's what I have right now, how is it looking to you?

//===============================================================

// Global Variables & Constants

//===============================================================

//Init the Pins used for PWM 

const int redPin = 9; // LED1 ANODE

const int greenPin = 10; // LED2 ANODE

const int bluePin = 11; // LED3 ANODE

// Init the Pins used for 10K pots

const int redPotPin = 0;

const int greenPotPin = 1;

const int bluePotPin = 2;

// Init our Vars

int currentColorValueRed;

int currentColorValueGreen;

int currentColorValueBlue;

//Init the Switch

const int modePin = 13; // Active HIGH, held low by 4.7K

int mode = 0; // Selector State (Initial state = ALL OFF)

int val = 0; // Pin 7 HIGH/LOW Status

int butState = 0; // Last Button State

int modeState = 0; // Last Mode State

boolean debug = 1; // 1 = Print Serial Enabled / 0 = disabled

//===============================================================

// SETUP

//===============================================================

void setup () {

pinMode(redPin, OUTPUT);

pinMode(greenPin, OUTPUT);

pinMode(bluePin, OUTPUT);

pinMode(modePin, INPUT);

  // Start off with the LED off.

  setColourRgb(0,0,0);

if (debug){

Serial.begin(9600);

Serial.print("Initial Mode: ");

Serial.println(mode);

Serial.print("Setup Complete\n");

}

}

void setColourRgb(unsigned int red, unsigned int green, unsigned int blue) {

  analogWrite(redPin, red);

  analogWrite(greenPin, green);

  analogWrite(bluePin, blue);

}

void loop(){

  If (digitalRead( modePin, HIGH) { 

     mode != mode // toggles mode on push 

   }

   If (mode==1) { 

     // code from loop in first example 

      // Read the voltage on each analog pin then scale down to 0-255 and inverting the value for common anode

  currentColorValueRed = (255 - map( analogRead(redPotPin), 0, 1024, 0, 255 ) );

  currentColorValueBlue = (255 - map( analogRead(bluePotPin), 0, 1024, 0, 255 ) );

  currentColorValueGreen = (255 - map( analogRead(greenPotPin), 0, 1024, 0, 255 ) );

// Write the color to each pin using PWM and the value gathered above

  analogWrite(redPin, currentColorValueRed);

  analogWrite(bluePin, currentColorValueBlue);

  analogWrite(greenPin, currentColorValueGreen);

   }

   else { 

     // code from loop in second example 

unsigned int rgbColour[3];

  // Start off with red.

  rgbColour[0] = 255;

  rgbColour[1] = 0;

  rgbColour[2] = 0;

  // Choose the colours to increment and decrement.

  for (int decColour = 0; decColour < 3; decColour += 1) {

    int incColour = decColour == 2 ? 0 : decColour + 1;

    // cross-fade the two colours.

    for(int i = 0; i < 255; i += 1) {

      rgbColour[decColour] -= 1;

      rgbColour[incColour] += 1;

      setColourRgb(rgbColour[0], rgbColour[1], rgbColour[2]);

      delay(5);

    }

  }

}

} 

SimpleOneButton.ino: In function 'void loop()':

SimpleOneButton:59: error: 'If' was not declared in this scope

SimpleOneButton:59: error: expected `;' before 'digitalRead'

SimpleOneButton:63: error: expected `;' before '{' token

SimpleOneButton:77: error: 'else' without a previous 'if'

awesomesauce! yeah it registers the mode but also then displays 0 right after it again, so I guess this is debouncing needed which i am scared of, because I dont understand all this 'millis' stuff. lol

Oh i didnt see the topic had gone to another page. using FALSE threw an error that it hadnt been defined, and before I saw you write LOW I had already used

'boolean mode = 0' which had worked for me.

My heart just fluttered even more when I set the value of mode to '1' first.

so booting it goes straight into the manual mode, and of course pressing the button then goes into the auto mode nicely.

so it looks like its working, apart from the fact once its in rainbow mode, I cant exit it to go back to manual. lol

my problem with that is because I have 2 for loops there isnt it? it wont look at the switch while its doing its thing there, which actually, is fine its kinda a feature. you have to hold the button for a few seconds before it will change mode!

So now I guess its onto debounce

We could kinda cheat...

create another boolean variable called debounce

boolean debounce = FALSE;

in the IF statement where we check the input pin, add a condition to check that this debounce variable is FALSE. ie

if (digitalRead(modePin)==HIGH && debounce==FALSE) {

inside the block where you toggle the mode, set this variable called 'debounce' to TRUE.

debounce = TRUE;

this will inhibit the if statement from running a second time.

Then add another block underneath that to reset the debounce variable once the button is released. ie

if (digitalRead(modePin)==LOW && debounce==TRUE) {
     debounce = FALSE;
}

We can look into methods of exiting the auto mode when everything else is working ok.

Let me know how you get on with this debounce process.

Do I need to declare true and false first before I create a boolean?

SimpleOneButton:33: error: 'FALSE' was not declared in this scope

SimpleOneButton.ino: In function 'void loop()':

SimpleOneButton:56: error: 'FALSE' was not declared in this scope

SimpleOneButton:59: error: 'TRUE' was not declared in this scope

Throw your code over...

//===============================================================
// Global Variables & Constants
//===============================================================


//Init the Pins used for PWM  
const int redPin = 9; // LED1 ANODE
const int greenPin = 10; // LED2 ANODE
const int bluePin = 11; // LED3 ANODE




// Init the Pins used for 10K pots
const int redPotPin = 0;
const int greenPotPin = 1;
const int bluePotPin = 2;




// Init our Vars
int currentColorValueRed;
int currentColorValueGreen;
int currentColorValueBlue;






//Init the Switch
const int modePin = 13; // Active HIGH, held low by 4.7K
boolean mode = 1; // Selector State (Initial state = ALL OFF)
//int val = 0; // Pin 13 HIGH/LOW Status
//int butState = 0; // Last Button State
//int modeState = 0; // Last Mode State
boolean debug = 1; // 1 = Print Serial Enabled / 0 = disabled
boolean debounce = FALSE;
//===============================================================
// SETUP
//===============================================================




void setup () {
 pinMode(redPin, OUTPUT);
 pinMode(greenPin, OUTPUT);
 pinMode(bluePin, OUTPUT);
 pinMode(modePin, INPUT);
 setColourRgb(0,0,0);
 Serial.begin(9600);
 }




 void setColourRgb(unsigned int red, unsigned int green, unsigned int blue) {
  analogWrite(redPin, red);
  analogWrite(greenPin, green);
  analogWrite(bluePin, blue);
}


void loop(){
if (digitalRead(modePin)==HIGH && debounce==FALSE) {  
  // toggles mode on push   
 mode = !mode; 
debounce = TRUE; 
if (digitalRead(modePin)==LOW && debounce==TRUE) {
     debounce = FALSE;
}

 Serial.println(mode);  
   } 
    
   if (mode==1) {  
 // Here we hve chosen our first loop AKA 'Manual Control'  
 // Read the voltage on each analog pin then scale down to 0-255 and inverting the value for common anode
  currentColorValueRed = (255 - map( analogRead(redPotPin), 0, 1024, 0, 255 ) );
  currentColorValueBlue = (255 - map( analogRead(bluePotPin), 0, 1024, 0, 255 ) );
  currentColorValueGreen = (255 - map( analogRead(greenPotPin), 0, 1024, 0, 255 ) );
 // Write the color to each pin using PWM and the value gathered above
  analogWrite(redPin, currentColorValueRed);
  analogWrite(bluePin, currentColorValueBlue);
  analogWrite(greenPin, currentColorValueGreen);
       
   }
  
   else {  
// Here we have chosen out 'Rainbow Cycle'  
   unsigned int rgbColour[3];
// Start off with red.
  rgbColour[0] = 255;
  rgbColour[1] = 0;
  rgbColour[2] = 0;
// Choose the colours to increment and decrement.
  for (int decColour = 0; decColour < 3; decColour += 1) {
    int incColour = decColour == 2 ? 0 : decColour + 1;
// cross-fade the two colours.
    for(int i = 0; i < 255; i += 1) {
      rgbColour[decColour] -= 1;
      rgbColour[incColour] += 1;
      setColourRgb(rgbColour[0], rgbColour[1], rgbColour[2]);
      delay(5);
    }
  }
}
     
   
} 

OK... Think I have it solved.

When you do a verify, the compiler will point you to each line that is causing an issue.

These lines will have either a TRUE or a FALSE in them

convert them to lowercase and they will turn orange

Seems to compile for me when those are repaired.

it does indeed. lost button functionality now though. nothing comes up in the monitor either. lol

it does indeed. lost button functionality now though. nothing comes up in the monitor either. lol

I think that's because you need to move the second IF block out of the first. Like this:

  if (digitalRead(modePin)==HIGH && debounce==false) {  
    // toggles mode on push   
    mode = !mode; 
    debounce = true; 
  }


  if (digitalRead(modePin)==LOW && debounce==true) {
    debounce = false;
  }

dude!!!!

thats so awesome it works! I REALLY APPRECIATE your help on this, I feel like I have learned a lot this past couple of days.

Having now set that delay time to a lot longer to make the rainbow effect more calm the button has to be pressed for a very long time.

Any ideas on what I should look at? It's going to mean getting rid of for loops and delays and doing all that 'millis' thing isnt it?

I also have another project for which the code is already written, that I would like to encorporate into this, would you be interested in a paid job to do that?

thanks again!

It may be possible to move the button checking code into a function, then call that function periodically within your 'for' loops, This would negate the necessity to wait for these cycles to continue.

Hope that makes sense, it's half 3 in the morning here.

Send me a PM and we can discuss your other project.

Paul