Help with joining two pieces of code.

Are you wanting your push-button to be latching? (ie Press once for 'on', and press once again for 'off')

latching in teh sense of press once to switch mode press again to switch back to teh other mode.

Looks like an interesting project.

OK. I would suggest having a 'Mode' variable that pressing the switch toggles, and using the SetColourRGB function for outputting in both modes.

Adapt the code that cwhyzee has suggested to toggle your variable on each button press, and then include an 'if' statement to conditionally execute either the colour cycle or manual-control code within the loop.

Forgive me if I am wrong, but by doing this, if the colour cycle mode was selected, would it not just cycle through the colours once and then stop? doesnt the 'lets look at the switch' part need to be inside the colour cycle loop?

sorry If I am being an utter, utter noob! lol

Does the current colour cycle code repeat?

it does if i am using that seperate sketch on its own.

it kinda seems like i need both of my modes here to be a 'loop within a loop' breaking out of the loop if the button is pressed. otherwise neither will function correctly.

forgive me if i am talking whack.

lol

Trying to get this working I changed this to work in a case.

here's what happened. when testing, I used only the manual rgb setting code. pressing the button to enter that mode would work but the color change would not respond to the pot position 'live' i can move the pot and the color will then change the next time I enter that mode....

when I tried to add the second chunk of code for the 'rainbow' effect into a different case i get the error: "setColourRGb was not declared in this scope"

here's how I'm looking up to this point.

//===============================================================

// Global Variables & Constants

//===============================================================

//Init the Pins used for PWM 

const int redPin = 9; // LED1 ANODE

const int greenPin = 10; // LED2 ANODE

const int bluePin = 11; // LED3 ANODE

// Init the Pins used for 10K pots

const int redPotPin = 0;

const int greenPotPin = 1;

const int bluePotPin = 2;

// Init our Vars

int currentColorValueRed;

int currentColorValueGreen;

int currentColorValueBlue;

//Init the Switch

const int modePin = 13; // Active HIGH, held low by 4.7K

int mode = 0; // Selector State (Initial state = ALL OFF)

int val = 0; // Pin 7 HIGH/LOW Status

int butState = 0; // Last Button State

int modeState = 0; // Last Mode State

boolean debug = 1; // 1 = Print Serial Enabled / 0 = disabled

//===============================================================

// SETUP

//===============================================================

void setup () {

pinMode(redPin, OUTPUT);

pinMode(greenPin, OUTPUT);

pinMode(bluePin, OUTPUT);

pinMode(modePin, INPUT);

setColourRgb(0,0,0);

if (debug){

Serial.begin(9600);

Serial.print("Initial Mode: ");

Serial.println(mode);

Serial.print("Setup Complete\n");

}

}

//===============================================================

// Main Loop

//===============================================================

void loop() {

val = digitalRead(modePin);

// If we see a change in button state, increment mode value

if (val != butState && val == HIGH){

mode++;

}

butState = val; // Keep track of most recent button state

// No need to keep setting pins *every* loop

if (modeState != mode){

// If no keys have been pressed yet don't execute

// the switch code below

// if (mode != 0) {

switch ( mode ) {

//case 1 is actually handled below as default

case 2:

unsigned int rgbColour[3];

  // Start off with red.

  rgbColour[0] = 255;

  rgbColour[1] = 0;

  rgbColour[2] = 0;

  // Choose the colours to increment and decrement.

  for (int decColour = 0; decColour < 3; decColour += 1) {

    int incColour = decColour == 2 ? 0 : decColour + 1;

    // cross-fade the two colours.

    for(int i = 0; i < 255; i += 1) {

      rgbColour[decColour] -= 1;

      rgbColour[incColour] += 1;

      setColourRgb(rgbColour[0], rgbColour[1], rgbColour[2]);

      delay(5);

    }

  }

}

void setColourRgb(unsigned int red, unsigned int green, unsigned int blue) {

  analogWrite(redPin, red);

  analogWrite(greenPin, green);

  analogWrite(bluePin, blue);

showState();

break;

case 3:

// Read the voltage on each analog pin then scale down to 0-255 and inverting the value for common anode

  currentColorValueRed = (255 - map( analogRead(redPotPin), 0, 1024, 0, 255 ) );

  currentColorValueBlue = (255 - map( analogRead(bluePotPin), 0, 1024, 0, 255 ) );

  currentColorValueGreen = (255 - map( analogRead(greenPotPin), 0, 1024, 0, 255 ) );

// Write the color to each pin using PWM and the value gathered above

  analogWrite(redPin, currentColorValueRed);

  analogWrite(bluePin, currentColorValueBlue);

  analogWrite(greenPin, currentColorValueGreen);

showState();

break;

default:

mode = 1;

// loop back to 1 by default, seems redundant but

// it also handles the "mode is > 3" problem

  showState();

break;

} // end switch

// } // end of "if mode = 0" check

} // end of ModeState check

modeState = mode; // Keep track of mode recent mode value

delay(10); // slow the loop just a bit for debounce

}

//===============================================================

// Subroutine

//===============================================================

void showState() {

if (debug){

Serial.print("Mode: ");

Serial.println(mode);

}

}

Trying to get this working I changed this to work in a case.

here's what happened. when testing, I used only the manual rgb setting code. pressing the button to enter that mode would work but the color change would not respond to the pot position 'live' i can move the pot and the color will then change the next time I enter that mode....

when I tried to add the second chunk of code for the 'rainbow' effect into a different case i get the error: "setColourRGb was not declared in this scope"

here's how I'm looking up to this point.

//===============================================================

// Global Variables & Constants

//===============================================================

//Init the Pins used for PWM 

const int redPin = 9; // LED1 ANODE

const int greenPin = 10; // LED2 ANODE

const int bluePin = 11; // LED3 ANODE

// Init the Pins used for 10K pots

const int redPotPin = 0;

const int greenPotPin = 1;

const int bluePotPin = 2;

// Init our Vars

int currentColorValueRed;

int currentColorValueGreen;

int currentColorValueBlue;

//Init the Switch

const int modePin = 13; // Active HIGH, held low by 4.7K

int mode = 0; // Selector State (Initial state = ALL OFF)

int val = 0; // Pin 7 HIGH/LOW Status

int butState = 0; // Last Button State

int modeState = 0; // Last Mode State

boolean debug = 1; // 1 = Print Serial Enabled / 0 = disabled

//===============================================================

// SETUP

//===============================================================

void setup () {

pinMode(redPin, OUTPUT);

pinMode(greenPin, OUTPUT);

pinMode(bluePin, OUTPUT);

pinMode(modePin, INPUT);

setColourRgb(0,0,0);

if (debug){

Serial.begin(9600);

Serial.print("Initial Mode: ");

Serial.println(mode);

Serial.print("Setup Complete\n");

}

}

//===============================================================

// Main Loop

//===============================================================

void loop() {

val = digitalRead(modePin);

// If we see a change in button state, increment mode value

if (val != butState && val == HIGH){

mode++;

}

butState = val; // Keep track of most recent button state

// No need to keep setting pins *every* loop

if (modeState != mode){

// If no keys have been pressed yet don't execute

// the switch code below

// if (mode != 0) {

switch ( mode ) {

//case 1 is actually handled below as default

case 2:

unsigned int rgbColour[3];

  // Start off with red.

  rgbColour[0] = 255;

  rgbColour[1] = 0;

  rgbColour[2] = 0;

  // Choose the colours to increment and decrement.

  for (int decColour = 0; decColour < 3; decColour += 1) {

    int incColour = decColour == 2 ? 0 : decColour + 1;

    // cross-fade the two colours.

    for(int i = 0; i < 255; i += 1) {

      rgbColour[decColour] -= 1;

      rgbColour[incColour] += 1;

      setColourRgb(rgbColour[0], rgbColour[1], rgbColour[2]);

      delay(5);

    }

  }

}

void setColourRgb(unsigned int red, unsigned int green, unsigned int blue) {

  analogWrite(redPin, red);

  analogWrite(greenPin, green);

  analogWrite(bluePin, blue);

showState();

break;

case 3:

// Read the voltage on each analog pin then scale down to 0-255 and inverting the value for common anode

  currentColorValueRed = (255 - map( analogRead(redPotPin), 0, 1024, 0, 255 ) );

  currentColorValueBlue = (255 - map( analogRead(bluePotPin), 0, 1024, 0, 255 ) );

  currentColorValueGreen = (255 - map( analogRead(greenPotPin), 0, 1024, 0, 255 ) );

// Write the color to each pin using PWM and the value gathered above

  analogWrite(redPin, currentColorValueRed);

  analogWrite(bluePin, currentColorValueBlue);

  analogWrite(greenPin, currentColorValueGreen);

showState();

break;

default:

mode = 1;

// loop back to 1 by default, seems redundant but

// it also handles the "mode is > 3" problem

  showState();

break;

} // end switch

// } // end of "if mode = 0" check

} // end of ModeState check

modeState = mode; // Keep track of mode recent mode value

delay(10); // slow the loop just a bit for debounce

}

//===============================================================

// Subroutine

//===============================================================

void showState() {

if (debug){

Serial.print("Mode: ");

Serial.println(mode);

}

}