element14 Community
element14 Community
    Register Log In
  • Site
  • Search
  • Log In Register
  • Community Hub
    Community Hub
    • What's New on element14
    • Feedback and Support
    • Benefits of Membership
    • Personal Blogs
    • Members Area
    • Achievement Levels
  • Learn
    Learn
    • Ask an Expert
    • eBooks
    • element14 presents
    • Learning Center
    • Tech Spotlight
    • STEM Academy
    • Webinars, Training and Events
    • Learning Groups
  • Technologies
    Technologies
    • 3D Printing
    • FPGA
    • Industrial Automation
    • Internet of Things
    • Power & Energy
    • Sensors
    • Technology Groups
  • Challenges & Projects
    Challenges & Projects
    • Design Challenges
    • element14 presents Projects
    • Project14
    • Arduino Projects
    • Raspberry Pi Projects
    • Project Groups
  • Products
    Products
    • Arduino
    • Avnet & Tria Boards Community
    • Dev Tools
    • Manufacturers
    • Multicomp Pro
    • Product Groups
    • Raspberry Pi
    • RoadTests & Reviews
  • About Us
    About the element14 Community
  • Store
    Store
    • Visit Your Store
    • Choose another store...
      • Europe
      •  Austria (German)
      •  Belgium (Dutch, French)
      •  Bulgaria (Bulgarian)
      •  Czech Republic (Czech)
      •  Denmark (Danish)
      •  Estonia (Estonian)
      •  Finland (Finnish)
      •  France (French)
      •  Germany (German)
      •  Hungary (Hungarian)
      •  Ireland
      •  Israel
      •  Italy (Italian)
      •  Latvia (Latvian)
      •  
      •  Lithuania (Lithuanian)
      •  Netherlands (Dutch)
      •  Norway (Norwegian)
      •  Poland (Polish)
      •  Portugal (Portuguese)
      •  Romania (Romanian)
      •  Russia (Russian)
      •  Slovakia (Slovak)
      •  Slovenia (Slovenian)
      •  Spain (Spanish)
      •  Sweden (Swedish)
      •  Switzerland(German, French)
      •  Turkey (Turkish)
      •  United Kingdom
      • Asia Pacific
      •  Australia
      •  China
      •  Hong Kong
      •  India
      •  Japan
      •  Korea (Korean)
      •  Malaysia
      •  New Zealand
      •  Philippines
      •  Singapore
      •  Taiwan
      •  Thailand (Thai)
      •  Vietnam
      • Americas
      •  Brazil (Portuguese)
      •  Canada
      •  Mexico (Spanish)
      •  United States
      Can't find the country/region you're looking for? Visit our export site or find a local distributor.
  • Translate
  • Profile
  • Settings
Arduino
  • Products
  • More
Arduino
Arduino Forum Help with joining two pieces of code.
  • Blog
  • Forum
  • Documents
  • Quiz
  • Events
  • Polls
  • Files
  • Members
  • Mentions
  • Sub-Groups
  • Tags
  • More
  • Cancel
  • New
Join Arduino to participate - click to join for free!
Actions
  • Share
  • More
  • Cancel
Forum Thread Details
  • State Not Answered
  • Replies 45 replies
  • Subscribers 416 subscribers
  • Views 4169 views
  • Users 0 members are here
  • led
  • rgb
Related

Help with joining two pieces of code.

e14 Contributor
e14 Contributor over 12 years ago

Hey Arduino Family!

 

I got y first arduino this week and i havent put it down since it arrived, I'm totally hooked.

I'm really a complete novice with coding but I am slowly starting to take it on board and can somewhat understand what the lines of code are doing (even thought I never thought that I would! lol)

 

So I am making this kind ambient lamp from RGB leds

 

I have these two pieces of code that work just fine on their own.

One cycles through colours nicely in a rainbow kinda effect and the other allows the colours to be set using 3 pots that are controlling the PWM signal.

 

What I would like to do is connect a momentary push button switch that takes it out of the rainbow cycle code and places it into 'manual' mode handing over control to the user.

I was thinking that this would perhaps look something like this:

The main loop for the rainbow effect is running, at the top of the loop check to see if the button is pressed and if it is then exit the loop and continue down the program, at which point it would hit the next loop which is the manual control section, perhaps in this loop it could look for the button being pressed again and switch back to the first loop putting it back into rainbow mode again'

 

The two sketches I have been using are pasted below.

any help that will start pointing me in the right direction would be really appreciated. thanks guys. image

 

RGB Rainbow

const int redPin = 11;

const int greenPin = 10;

const int bluePin = 9;

 

void setup() {

  // Start off with the LED off.

  setColourRgb(0,0,0);

}

 

void loop() {

  unsigned int rgbColour[3];

 

  // Start off with red.

  rgbColour[0] = 255;

  rgbColour[1] = 0;

  rgbColour[2] = 0;

 

  // Choose the colours to increment and decrement.

  for (int decColour = 0; decColour < 3; decColour += 1) {

    int incColour = decColour == 2 ? 0 : decColour + 1;

 

    // cross-fade the two colours.

    for(int i = 0; i < 255; i += 1) {

      rgbColour[decColour] -= 1;

      rgbColour[incColour] += 1;

    

      setColourRgb(rgbColour[0], rgbColour[1], rgbColour[2]);

      delay(5);

    }

  }

}

 

void setColourRgb(unsigned int red, unsigned int green, unsigned int blue) {

  analogWrite(redPin, red);

  analogWrite(greenPin, green);

  analogWrite(bluePin, blue);

}

 

 

 

=================================================

 

RGB Color Chooser

 

// Init the Pins used for PWM

const int redPin = 9;

const int greenPin = 10;

const int bluePin = 11;

 

// Init the Pins used for 10K pots

const int redPotPin = 0;

const int greenPotPin = 1;

const int bluePotPin = 2;

 

// Init our Vars

int currentColorValueRed;

int currentColorValueGreen;

int currentColorValueBlue;

 

void setup()

{

  pinMode(redPin, OUTPUT);

  pinMode(greenPin, OUTPUT);

  pinMode(bluePin, OUTPUT);

}

 

void loop()

{

// Read the voltage on each analog pin then scale down to 0-255 and inverting the value for common anode

  currentColorValueRed = (255 - map( analogRead(redPotPin), 0, 1024, 0, 255 ) );

  currentColorValueBlue = (255 - map( analogRead(bluePotPin), 0, 1024, 0, 255 ) );

  currentColorValueGreen = (255 - map( analogRead(greenPotPin), 0, 1024, 0, 255 ) );

 

// Write the color to each pin using PWM and the value gathered above

  analogWrite(redPin, currentColorValueRed);

  analogWrite(bluePin, currentColorValueBlue);

  analogWrite(greenPin, currentColorValueGreen);

 

}

  • Sign in to reply
  • Cancel
  • gadget.iom
    0 gadget.iom over 12 years ago in reply to e14 Contributor

    OK... Think I have it solved.

    When you do a verify, the compiler will point you to each line that is causing an issue.

    These lines will have either a TRUE or a FALSE in them

    convert them to lowercase and they will turn orange image

     

    Seems to compile for me when those are repaired.

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Verify Answer
    • Cancel
  • e14 Contributor
    0 e14 Contributor over 12 years ago in reply to gadget.iom

    it does indeed. lost button functionality now though. nothing comes up in the monitor either. lol

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Verify Answer
    • Cancel
  • gadget.iom
    0 gadget.iom over 12 years ago in reply to e14 Contributor

    I think that's because you need to move the second IF block out of the first. Like this:

      if (digitalRead(modePin)==HIGH && debounce==false) {  
        // toggles mode on push   
        mode = !mode; 
        debounce = true; 
      }
    
    
      if (digitalRead(modePin)==LOW && debounce==true) {
        debounce = false;
      }

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Verify Answer
    • Cancel
  • e14 Contributor
    0 e14 Contributor over 12 years ago in reply to e14 Contributor

    dude!!!!

    thats so awesome it works! I REALLY APPRECIATE your help on this, I feel like I have learned a lot this past couple of days.

    Having now set that delay time to a lot longer to make the rainbow effect more calm the button has to be pressed for a very long time.

    Any ideas on what I should look at? It's going to mean getting rid of for loops and delays and doing all that 'millis' thing isnt it?

     

    I also have another project for which the code is already written, that I would like to encorporate into this, would you be interested in a paid job to do that?

    thanks again!

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Verify Answer
    • Cancel
  • gadget.iom
    0 gadget.iom over 12 years ago in reply to e14 Contributor

    It may be possible to move the button checking code into a function, then call that function periodically within your 'for' loops, This would negate the necessity to wait for these cycles to continue.

    Hope that makes sense, it's half 3 in the morning here.

     

    Send me a PM and we can discuss your other project.

     

    Paul

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Verify Answer
    • Cancel
<
element14 Community

element14 is the first online community specifically for engineers. Connect with your peers and get expert answers to your questions.

  • Members
  • Learn
  • Technologies
  • Challenges & Projects
  • Products
  • Store
  • About Us
  • Feedback & Support
  • FAQs
  • Terms of Use
  • Privacy Policy
  • Legal and Copyright Notices
  • Sitemap
  • Cookies

An Avnet Company © 2026 Premier Farnell Limited. All Rights Reserved.

Premier Farnell Ltd, registered in England and Wales (no 00876412), registered office: Farnell House, Forge Lane, Leeds LS12 2NE.

Follow element14

  • X
  • Facebook
  • linkedin
  • YouTube