Making a Flash game with arduino uno; one glitch keeps happening

My game works perfectly except for the fact that the gameover doesn't worK. It only does game over if line2 hits it. Pleased help for a solution. Here is the code:

#include <LiquidCrystal.h>

LiquidCrystal lcd(12,11,7,4,3,2);

int pbu = 13;

int pbd = 10;

int pbr = 8;

int pbl = 6;

int currentcirc = 0;

int xp = 0;

int yp = 0;

int xlp;

int ylp;

int curline;

int shootdelay = 1250;

int prevline;

int ranline;

int gameover = false;

byte circle1[8] =

{

B01110,

B11111,

B01110,

B00000,

};

byte circle2[8] =

{

B00000,

B01110,

B11111,

B01110,

B00000,

};

byte circle3[8] =

{

B00000,

B01110,

B11111,

B01110,

B00000,

};

byte circle4[8] =

{

B00000,

B01110,

B11111,

B01110,

};

byte line1[8] =

{

B11111,

B00000,

};

byte line2[8] =

{

B00000,

B11111,

B00000,

};

byte line3[8] =

{

B00000,

B11111,

B00000,

};

byte line4[8] =

{

B00000,

B11111,

B00000,

};

void setup()

{

lcd.begin(16,2);

pinMode(9,OUTPUT);

analogWrite(9,50);

pinMode(pbu,INPUT);

pinMode(pbd,INPUT);

pinMode(pbr,INPUT);

pinMode(pbl,INPUT);

lcd.createChar(0,circle1);

lcd.createChar(1,circle2);

lcd.createChar(2,circle3);

lcd.createChar(3,circle4);

lcd.createChar(4,line1);

lcd.createChar(5,line2);

lcd.createChar(6,line3);

lcd.createChar(7,line4);

xlp = 16;

}

void loop()

{

if (gameover != true)

{

lcd.setCursor(0,0);

if (xlp <2)

{

if (curline == 4 && ylp == yp)

{

if (currentcirc != 0)

{

gameover = true;

}

if (curline == 5 && ylp == yp)

{

if (currentcirc != 3)

{

gameover = true;

}

if (curline == 6 && ylp == yp)

{

gameover == true;

}

if (curline == 7 && ylp == yp)

{

if (currentcirc == 3)

{

gameover = true;

}

if (xlp == 15)

{ylp = random(0,2);

curline = random(4,8);

}

if (xlp == 1)

{

xlp = 16;

}

if (digitalRead(pbu) == HIGH)

{

if (currentcirc == 0)

{

if (yp == 1)

{

yp = yp - 1;

currentcirc = 3;

}

else

{

currentcirc = currentcirc - 1;

}

if (digitalRead(pbd) == HIGH)

{

if (currentcirc == 3)

{

if (yp == 0)

{

yp = yp + 1;

currentcirc = 0;

}

else

{

currentcirc = currentcirc + 1;

}

//if (digitalRead(pbr) == HIGH)

//{

//if (xp < 16)

//{

//xp = xp + 1;

//}

//if (digitalRead(pbl) == HIGH)

//{

//if (xp > 0)

//{

//xp = xp - 1;

//}

if (xp > 16)

{

xp = 16;

}

if (yp > 1)

{

yp = 1;

}

xlp = xlp - 1;

lcd.setCursor(xp,yp);

lcd.write((byte)currentcirc);

shoot();

delay(100);

lcd.clear();

shootdelay = shootdelay - 15;

}

else

{

lcd.clear();

lcd.setCursor(6,0);

lcd.print("GAME");

lcd.setCursor(6,1);

lcd.print("OVER");

if (digitalRead(pbu) == HIGH)

{

gameover = false;

shootdelay= 1250;

}

void shoot()

{

if (shootdelay < 125)

{

shootdelay = 115;

}

delay(shootdelay);

lcd.setCursor(xlp,ylp);

lcd.write((byte)curline);

}

Parents

0 mcb1 over 10 years ago
Kyle

For future reference use the >> symbol and select Syntax Highlighting then C++ to make you code more like in the IDE.

I think you'll find your problem is this line

if (curline == 6 && ylp == yp) { gameover == true; }

It seems to be a simple typo.
You have a lot of nested loops, which you may wish to revise to see if there is a more elegant and simple way to achieve the same thing.

Mark
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 Former Member over 10 years ago in reply to mcb1

Mark,

Thanks for the tip on the syntax and for pointing out that typo. The only problem is that it glitches to not show up game over for all the curlines except for 5.(that typo will probably fix the curline6 one) I am bewildered on what the problem could be on the other ones.

-Kyle
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel

Reply

0 Former Member over 10 years ago in reply to mcb1

Mark,

Thanks for the tip on the syntax and for pointing out that typo. The only problem is that it glitches to not show up game over for all the curlines except for 5.(that typo will probably fix the curline6 one) I am bewildered on what the problem could be on the other ones.

-Kyle
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel

Children

0 mcb1 over 10 years ago in reply to Former Member
Kyle

You basically have a single 'if' statement ( if (gameover != true) ), and then a lot of checks.
It seems you never exit the if statement when you change the gameover state.
if (curline == 4 && ylp == yp) { if (currentcirc != 0) { gameover = true; } }

You may be better changing the 'game over' display to a separate routine and call it when you change the state.

You can also use 'While' instead of this
if (gameover != true)

Mark
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 Former Member over 10 years ago in reply to mcb1

Mark

Thanks for all your help. I will fix the typo and replace big if statement with a small while statement and see if it fixes my problem. Also, what did you mean when you said I had lots of nested ifs? and how would I clean up or fix them?

Kyle

PS Sorry for the rookie mistakes and such. This is only my 4th day with an arduino and my 3rd sketch.
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel
0 mcb1 over 10 years ago in reply to Former Member

Sorry for the rookie mistakes and such. This is only my 4th day with an arduino and my 3rd sketch

We all have to start somewhere.

You can add some serial.println and a delay for debugging to see if it is going where you want it to

A nested loop is a loop inside a loop inside another loop.

When I'm doing something I tend to draw out a bit of a flow diagram to flesh it out.
This can highlight where you can do common things, or perhaps a better way.

Your first 4 nested 'if' statements have the same " ... && ylp == yp) ...", so you could probably check that and then use the switch case for the other part.

Mark
Cancel
Vote Up 0 Vote Down

Sign in to reply

Verify Answer

Cancel