rebuilding a accordion with esp32

Hi,

You've got something weird going on with the switch wiring. The switch has four connections. I've highlighted with blue circles the two connections that are internally permanently connected together, and in yellow are the other two connectors that are internally permanently connected together too. It's a mechanical thing, they are constructed like that for ease of manufacture and mounting.

Anyway, you have a green wire going to one of the blue connections, and a black wire going to the other blue connection. Since they are internally connected, that means you've got a resistor wired between the supply and ground, which doesn't do anything (except consume current). It also means all the inputs on the '165 chips are actually floating when no button is pressed, which isn't what you probably wanted.

Also the input on the first '165 chip should be connected to either ground or the supply, it doesn't matter which (it shouldn't be left floating).

Okey,  i Will rebuild The curuit tomorrow and change The things you adviced me,  but now i have some things to look i to.  So I Will " kill my darling"  and begin with a fresh rebuild. 

...

But i have one more question about The for loops

The 1 loop is to place The Buttons in The right order?

The 2 loop is to tell how many Button it is?

Am i right?

the loop starts with the value of i set to 24 and i is used then decremented by 8 until it reaches 0.

In the 2nd code segment the value of i is set at 56 and i is then used then decremented by 8 until it reaches 0.

The variable optionSwitch is an unsigned 32-bit integer.  The reason that it is set to 24 in the working code is that it reads in 8 bits when the counter i is equal to 24, 16, 8, and 0 and shifts it into optionSwitch by the value of i for a total of 32 bits. The loop in the code that doesn't work is trying to shift 64 bits into a 32-bit integer.  Non-working code is shown below.

  // Reading one 74HC165 at a time and combining them into a 32 bit variable
  // The last 74HC165 is at the bottom, but the switches start numbering
  // at the top. So the first byte has to be shifted into the highest place.
  uint32_t optionSwitch = 0;
  for( int i=56; i>=0; i-=8)
  {
    optionSwitch |= ((uint32_t) ReadOne165()) << i;
  }

  for( int i = 0; i<64; i++)
  {
    if( bitRead( optionSwitch, i) != bitRead( oldOptionSwitch,i))
    {
      Serial.print( "Switch ");
      Serial.print( i);
      Serial.print( " is now ");
      Serial.println( bitRead( optionSwitch, i) == 0 ? "down ↓" : "up   ↑");
    }
  }

If your compiler allows uint64_t you can try that for both optionSwitch and oldOptionSwitch.  Else could use two uint32_t.