element14 Community
element14 Community
    Register Log In
  • Site
  • Search
  • Log In Register
  • About Us
  • Community Hub
    Community Hub
    • What's New on element14
    • Feedback and Support
    • Benefits of Membership
    • Personal Blogs
    • Members Area
    • Achievement Levels
  • Learn
    Learn
    • Ask an Expert
    • eBooks
    • element14 presents
    • Learning Center
    • Tech Spotlight
    • STEM Academy
    • Webinars, Training and Events
    • Learning Groups
  • Technologies
    Technologies
    • 3D Printing
    • FPGA
    • Industrial Automation
    • Internet of Things
    • Power & Energy
    • Sensors
    • Technology Groups
  • Challenges & Projects
    Challenges & Projects
    • Design Challenges
    • element14 presents Projects
    • Project14
    • Arduino Projects
    • Raspberry Pi Projects
    • Project Groups
  • Products
    Products
    • Arduino
    • Avnet Boards Community
    • Dev Tools
    • Manufacturers
    • Multicomp Pro
    • Product Groups
    • Raspberry Pi
    • RoadTests & Reviews
  • Store
    Store
    • Visit Your Store
    • Choose another store...
      • Europe
      •  Austria (German)
      •  Belgium (Dutch, French)
      •  Bulgaria (Bulgarian)
      •  Czech Republic (Czech)
      •  Denmark (Danish)
      •  Estonia (Estonian)
      •  Finland (Finnish)
      •  France (French)
      •  Germany (German)
      •  Hungary (Hungarian)
      •  Ireland
      •  Israel
      •  Italy (Italian)
      •  Latvia (Latvian)
      •  
      •  Lithuania (Lithuanian)
      •  Netherlands (Dutch)
      •  Norway (Norwegian)
      •  Poland (Polish)
      •  Portugal (Portuguese)
      •  Romania (Romanian)
      •  Russia (Russian)
      •  Slovakia (Slovak)
      •  Slovenia (Slovenian)
      •  Spain (Spanish)
      •  Sweden (Swedish)
      •  Switzerland(German, French)
      •  Turkey (Turkish)
      •  United Kingdom
      • Asia Pacific
      •  Australia
      •  China
      •  Hong Kong
      •  India
      •  Korea (Korean)
      •  Malaysia
      •  New Zealand
      •  Philippines
      •  Singapore
      •  Taiwan
      •  Thailand (Thai)
      • Americas
      •  Brazil (Portuguese)
      •  Canada
      •  Mexico (Spanish)
      •  United States
      Can't find the country/region you're looking for? Visit our export site or find a local distributor.
  • Translate
  • Profile
  • Settings
Arduino
  • Products
  • More
Arduino
Arduino Forum If statements and functions.
  • Blog
  • Forum
  • Documents
  • Quiz
  • Events
  • Polls
  • Files
  • Members
  • Mentions
  • Sub-Groups
  • Tags
  • More
  • Cancel
  • New
Join Arduino to participate - click to join for free!
Actions
  • Share
  • More
  • Cancel
Forum Thread Details
  • Replies 11 replies
  • Subscribers 385 subscribers
  • Views 1841 views
  • Users 0 members are here
Related

If statements and functions.

SteveE14
SteveE14 over 2 years ago

If statements and functions.
I am new to Arduino, can you help me please?

The sketch is supposed to only run "myfunction" if "EnableState" is high. However, it runs the function irrespective of the state of "EnableState"

Thanks for taking the time to read this.

bool EnableState;
 void setup() {
// rem whatever

EnableState = LOW;  
EnableState = HIGH;
 Serial.begin(9600); // opens serial port, sets data rate to 9600 bps
}

void loop() {

 Serial.println("In Void loop");
 Serial.println(EnableState);
      if (EnableState==HIGH);{
      MyFunction();

}
}

void MyFunction(){

    Serial.println("MyFunction");
      delay(1000);
}

  • Sign in to reply
  • Cancel

Top Replies

  • shabaz
    shabaz over 2 years ago +4
    Hi, The easiest way to spot this kind of issue is to paste it into a decent C/C++ editor, e.g. Visual Code. Then, if you press the Format option (Alt-Shift-F) the problem instantly becomes visible:
  • mayermakes
    mayermakes over 2 years ago +3
    you are litterally setting it to high in line 6, that is the last state it has before the loop, therefore it executes, if you delete line 6 or put it before line 5, the opposite will happen.
  • mayermakes
    mayermakes over 2 years ago in reply to shabaz +2
    i did not catch the stray ; , but still it wil lalso execute because of the declaration in setup.
Parents
  • shabaz
    shabaz over 2 years ago

    Hi,

    The easiest way to spot this kind of issue is to paste it into a decent C/C++ editor, e.g. Visual Code. Then, if you press the Format option (Alt-Shift-F) the problem instantly becomes visible:

    image

    • Cancel
    • Vote Up +4 Vote Down
    • Sign in to reply
    • Cancel
  • mayermakes
    mayermakes over 2 years ago in reply to shabaz

    i did not catch the stray ; , but still it wil lalso execute because of the declaration in setup.

    • Cancel
    • Vote Up +2 Vote Down
    • Sign in to reply
    • Cancel
  • shabaz
    shabaz over 2 years ago in reply to mayermakes

    Some IDEs will catch that, it's a shame that the Arduino IDE is quite basic. This is CLion:

    image

    (EDIT: just realized my 'bob' example is not quite the same)

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Cancel
Reply
  • shabaz
    shabaz over 2 years ago in reply to mayermakes

    Some IDEs will catch that, it's a shame that the Arduino IDE is quite basic. This is CLion:

    image

    (EDIT: just realized my 'bob' example is not quite the same)

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Cancel
Children
  • SteveE14
    SteveE14 over 2 years ago in reply to shabaz

    Thank you for your reply, that is simply so I can REM // whichever value.

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Cancel
element14 Community

element14 is the first online community specifically for engineers. Connect with your peers and get expert answers to your questions.

  • Members
  • Learn
  • Technologies
  • Challenges & Projects
  • Products
  • Store
  • About Us
  • Feedback & Support
  • FAQs
  • Terms of Use
  • Privacy Policy
  • Legal and Copyright Notices
  • Sitemap
  • Cookies

An Avnet Company © 2025 Premier Farnell Limited. All Rights Reserved.

Premier Farnell Ltd, registered in England and Wales (no 00876412), registered office: Farnell House, Forge Lane, Leeds LS12 2NE.

ICP 备案号 10220084.

Follow element14

  • X
  • Facebook
  • linkedin
  • YouTube