Hi, I need some hellp with my code structure.

Question

for you that don't know I grew up writing C code. So my Code Base has multiple files currently working on my Landing Gear for my sim. 
 I have the following files in the LandingGear directory: LandingGear.ino isr1.c through isr5.c lamps.c and landingGear.h 
 
 so in lamps.c i have my code for the lamp test. 
 void lampTest( int state ){ for( int count = 0; count < 10; count++;) { digitalWrite( Lamps.pin[count] ); } } 
 it is called from isr4 (isr4.c) 
 it is also declared in landingGear.h 
 #define TRUE 1 #define FALSE -1 #define ON 1 #define OFF 0 
 /************************** Prototypes *****************************/ 
 void lampTest( int state ); void lamp( Lamps.pin[count], int state ); void blink( Lamps.pin[count] ); 
 typedef struct Lamps{ char name[]; char name[]; lamp} Lamps[] = { {22, "RIGHT", "RED"}, {23, "NOSE", "RED"}, {24, "LEFT", "RED"}, {25, "RIGHT", "GREEN"}, {26, "NOSE", "GREEN"}, {27, "LEFT", "GREEN"}, {28, "WARNnose", "GREEN"}, {29, "WARNgear, "ORANGE"}, {30, "WARNnoseDis, "BLUE"}, {31, "WARNskid", "RED"}}; 
 
 and pucks with this isr4.c:2:12: error: &lsquo;ON&rsquo; undeclared (first use in this function) lampTest( ON ); 
 cam anybody give me a straight answer why this happens??? 
 
 ~~ thanks C Harrison

phoenixcomm · Accepted Answer

shabaz yess. I agree with most. but 4 is well a toss-up. in a large production codebase, I agree because I use it for debugging. ifndef -endif is very good where you have two or versions in the same package. you just the define the on you wish to use. But this is not the case! So I decided not to use that "structure" 
 Nope, Nada, Old wifes tail. #6 First its a great place to store all of your vars, defs , structs, etc. You just should not put active code segments there here are few that break that rule too: 
 definition of PI, and we don't have one. so we can get lazy by doing something like this: const int PI = 3.14 ( but it needs 16 decimals there). now question why the const its not needed. It just tells the compiler that wait you can't change this value, and I normally don't use it. you could use atan2() a math function. like this: const double pi = atan2(1,1) but why? #define PI atan2(1,1) and let the compiler figure it out. and btw once it is defined you can not change the value. 
 and I have one more for you how about the square of a number, nope C does not have one either. to square a number you have to multiply it by itself. so you could end up here. square( n ) but wait you need to declare what type is n. so that's not going to work again here is the solution #define SQ (a)*(a) but we can change the SQ to something more useable. what about the @ symbol? or &fnof; t he symbol so A&sup2; + B&sup2; = C&sup2; would become A&sup2; + B&sup2; = C&sup2; . A&fnof; + B&fnof; = C&fnof; I kinda ike it. So the #define is this: #define &fnof; (n)*(n) and there is no rule agaist it. beauty rains. 
 ~~CAH

Hi, I need some hellp with my code structure.

Top Replies