element14 Community
element14 Community
    Register Log In
  • Site
  • Search
  • Log In Register
  • About Us
  • Community Hub
    Community Hub
    • What's New on element14
    • Feedback and Support
    • Benefits of Membership
    • Personal Blogs
    • Members Area
    • Achievement Levels
  • Learn
    Learn
    • Ask an Expert
    • eBooks
    • element14 presents
    • Learning Center
    • Tech Spotlight
    • STEM Academy
    • Webinars, Training and Events
    • Learning Groups
  • Technologies
    Technologies
    • 3D Printing
    • FPGA
    • Industrial Automation
    • Internet of Things
    • Power & Energy
    • Sensors
    • Technology Groups
  • Challenges & Projects
    Challenges & Projects
    • Design Challenges
    • element14 presents Projects
    • Project14
    • Arduino Projects
    • Raspberry Pi Projects
    • Project Groups
  • Products
    Products
    • Arduino
    • Avnet Boards Community
    • Dev Tools
    • Manufacturers
    • Multicomp Pro
    • Product Groups
    • Raspberry Pi
    • RoadTests & Reviews
  • Store
    Store
    • Visit Your Store
    • Choose another store...
      • Europe
      •  Austria (German)
      •  Belgium (Dutch, French)
      •  Bulgaria (Bulgarian)
      •  Czech Republic (Czech)
      •  Denmark (Danish)
      •  Estonia (Estonian)
      •  Finland (Finnish)
      •  France (French)
      •  Germany (German)
      •  Hungary (Hungarian)
      •  Ireland
      •  Israel
      •  Italy (Italian)
      •  Latvia (Latvian)
      •  
      •  Lithuania (Lithuanian)
      •  Netherlands (Dutch)
      •  Norway (Norwegian)
      •  Poland (Polish)
      •  Portugal (Portuguese)
      •  Romania (Romanian)
      •  Russia (Russian)
      •  Slovakia (Slovak)
      •  Slovenia (Slovenian)
      •  Spain (Spanish)
      •  Sweden (Swedish)
      •  Switzerland(German, French)
      •  Turkey (Turkish)
      •  United Kingdom
      • Asia Pacific
      •  Australia
      •  China
      •  Hong Kong
      •  India
      •  Korea (Korean)
      •  Malaysia
      •  New Zealand
      •  Philippines
      •  Singapore
      •  Taiwan
      •  Thailand (Thai)
      • Americas
      •  Brazil (Portuguese)
      •  Canada
      •  Mexico (Spanish)
      •  United States
      Can't find the country/region you're looking for? Visit our export site or find a local distributor.
  • Translate
  • Profile
  • Settings
Arduino
  • Products
  • More
Arduino
Arduino Forum HELP! - Arduino code isn't working!
  • Blog
  • Forum
  • Documents
  • Quiz
  • Events
  • Polls
  • Files
  • Members
  • Mentions
  • Sub-Groups
  • Tags
  • More
  • Cancel
  • New
Join Arduino to participate - click to join for free!
Actions
  • Share
  • More
  • Cancel
Forum Thread Details
  • Replies 6 replies
  • Subscribers 395 subscribers
  • Views 394 views
  • Users 0 members are here
  • arduino-robot
  • arduino uno
  • arduino ide
  • arduino_code
  • arduino uno r3
  • arduino
Related

HELP! - Arduino code isn't working!

braedan
braedan over 9 years ago

Hello!

I have my arduino uno hooked up to a L293D dual h-bridge with an LED on each out put. So if the positive voltage goes out one terminal, one of the LEDs will light up to indicate the motor will be turning in that direction. Again there is not motor currently wired into it, and i have confirmed that this system works, no circuit problems here! I'm trying to create a simple closed loop feed back system to control to control a geared dc motor like a servo by attaching a potentiometer (variable resistor) to the end of the motor shaft to give the arduino some data to work with. In this testing stage in addition to the two LEDs hooked up to the h-bridge a pot-meter by itself is being used so i can mimic the rotation of the motors shaft with out a motor. My problem is when I start my arduino (with the pot-meter off the target value) the led lights up (good so far), but when i turn the meter past it it stays on. It flickers when the value is in range but never turns the other direction.

 

my code:

int enablepin = 9;
int mpin1 = 6;
int mpin2 = 3;


int desiredpos;
int ifint;


int feedbackpin = A5;
int mindegrees = 0;
int maxdegrees = 180;
int minfeedback = 40;;
int maxfeedback = 980;
int tolerance = 2;


int getPos(int analogPinn)
{
  return map(analogRead(analogPinn), minfeedback, maxfeedback, mindegrees, maxdegrees);
}


void Seek(int left_pin, int right_pin, int analogPin, int pos, int Speed)
{
  int currentpos = getPos(analogPin);
  Serial.println(currentpos);
  int currentpin;
  int target = map(pos, mindegrees, maxdegrees, minfeedback, maxfeedback);
  
  if(currentpos < target)
  {
    if (target < 90)
    {
      currentpin = right_pin;
    }
    if (target > 90)
    {
      currentpin = left_pin;
    }
  }
  if(currentpos > target)
  {
    if (target > 90)
    {
      currentpin = right_pin;
    }
    if (target < 90)
    {
      currentpin = left_pin;
    }
  }


  analogWrite(currentpin, Speed);


  while(abs(analogRead(analogPin) - target) > tolerance){}


  analogWrite(currentpin, 0);
}


void setup() {
  Serial.begin(9600);
  Serial.print("");
  pinMode(enablepin, OUTPUT);
  pinMode(mpin1, OUTPUT);
  pinMode(mpin2, OUTPUT);
  digitalWrite(enablepin, HIGH);
  digitalWrite(mpin1, LOW);
  digitalWrite(mpin2, LOW);
  desiredpos = 50;
  //Seek(mpin1, mpin2, feedbackpin, 50, 5);
}


void loop() {
  ifint = (getPos - desiredpos);
  if (ifint > tolerance)
  {
     Seek(mpin1, mpin2, feedbackpin, desiredpos, 5);
  }
  
}

  • Sign in to reply
  • Cancel
  • jw0752
    jw0752 over 9 years ago

    Does the other LED light up if you start your arduino with the pot off target in the other direction?

     

    John

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Cancel
  • mcb1
    mcb1 over 9 years ago

    It strikes me that you have not declared what AnalogPinn or AnalogPin is.

     

    You do have a feedbackpin = A5.

     

    Mark

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Cancel
  • kulky64
    kulky64 over 9 years ago

    Your program has bunch of errors:

    1. As Mark mentioned on line 80 you are calling getPos without any perameter (does that even compile?). It should be something like this:

    ifint = (getPos(feedbackpin) - desiredpos);

    2. On line 81 you should calculate absolute value of ifint, this is why your program reacts only in one directon. Say for example you have your pot in 20 degrees position and your desired position is 50 deg, then

    ifint = 20 - 50 = -30

    and condition if (-30 > 2) is FALSE and nothing will happen.

    3. You have mismatch in your units. In function getPos you are mapping analog value of your pot position from range (40; 980) to range (0; 180). But on line 29 you are mapping target value in the opposite direction - from (0; 180) to (40; 980). Then you compare variables currentpos and target in incompatible ranges. Choose one unit a do all your work in this unit.

    4. Didn't quite understand the logic behind these conditions:

    if (target < 90)

    {

       currentpin = right_pin;

    }

    if (target > 90)

    {

       currentpin = left_pin;

    }

    Why are you comparing target against 90? Not to mention your target variable IS NOT in degrees (see point 3).

    5. You are generating PWM on certain pin, but you doesn't care what happens with your other pin. If you generate PWM on one pin, the other pin should be writen to 0 and vice versa.

    6. While loop on line 58 - see point 3.

    7. You are controlling your motor with ON-OFF control. I would implement at least P regulator.

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Cancel
  • braedan
    braedan over 9 years ago in reply to kulky64

    Thank you for your help! I got it to work flawlessly with several major tweaks.

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Cancel
  • braedan
    braedan over 9 years ago in reply to mcb1

    Oh no! Didn't catch that...

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Cancel
  • Robert Peter Oakes
    Robert Peter Oakes over 9 years ago in reply to kulky64

    For those not knowing, "P" is for Proportional, one term in a typical PID controller ( Proportional, Integral, Derivative ) used in many control solutions throughout the industry

     

    P gives you an output proportional to the error (Setpoint - actual/feedback) so as you get close to the set point, the output will reduce. (No difference no output, from this function)

    I gives you the Integral of the input so the output is related to the magnitude of the error and the duration the error remains so the output of this function will slowly increase or decrease while there is an error present, if it is a small error then the rate of change will be slower.

    D gives a derivative output based on the rate of change of the error over time, in other words it tries to react quickly and in opposition to a changing error to try and keep the setpoint and actual/feedback equal

     

    these parameters need to be "TUNED" in order to prevent oscillation or hunting of the output but at the same time maintain an optimal response to changes in the load.

     

    the output of each function are typically summed to provide the final output control

     

    There are libraries for Arduino and other controllers that provide this functionality already so no need to invent your own if you dont want to.

    See wikipedia for more info or search google etc.

     

    https://en.wikipedia.org/wiki/PID_controller

    • Cancel
    • Vote Up 0 Vote Down
    • Sign in to reply
    • Cancel
element14 Community

element14 is the first online community specifically for engineers. Connect with your peers and get expert answers to your questions.

  • Members
  • Learn
  • Technologies
  • Challenges & Projects
  • Products
  • Store
  • About Us
  • Feedback & Support
  • FAQs
  • Terms of Use
  • Privacy Policy
  • Legal and Copyright Notices
  • Sitemap
  • Cookies

An Avnet Company © 2025 Premier Farnell Limited. All Rights Reserved.

Premier Farnell Ltd, registered in England and Wales (no 00876412), registered office: Farnell House, Forge Lane, Leeds LS12 2NE.

ICP 备案号 10220084.

Follow element14

  • X
  • Facebook
  • linkedin
  • YouTube