Engine Management

My favorite word errata.  I had the chance to compile the code, and found a few "undocumented features" (bugs) in what I posted. The good news is half the files are clean.

A2D.c

EEPROM.c

LATCHES.c

and UART.c

The main issue with stuff was undeclared variables and constants, so start at the top.

types.h

line 71 should be DEG_PER_REV not DEGS_PER_REV

line 73-75 should be declared as long so add an 'L' to the end of the numbers

...additions.  Because the variables are shared globally for now, need to add to the extern list

extern UByte tkHi, tkLo;

extern UByte cylCt;

extern UWord tkEv[];

extern UWord tkSt[];

TIMERS.c

Like I said, setTach needed to be defined, so make a call to access one of the latches.

void setLatch(UByte, bool);

void setTach(bool t) { setLatch(23, t); }

IGNCRKCAM.c

This one had a lot of things missing, mostly What I think of as loop closing stuff.

add line #define FIVE_DEG  466

add prototype SLong getTime1(void);

line 34: correct spelling SLong camTime not SLong camTIme

add some variables

     UByte cylCt;

     UWord tkEv[8];

     UWord tkSt[8];

add a switch detection for cam detected

     UByte camDet = 0;

     bool isCamDet(void) { return (camDet != 0); }

     void setCamDet(bool t) { camDet = t ? 1 : 0; }

line 50 remove toothAfterCam = 0; (just used for first example).

declare variable in rtUpdateIgn routine

     UByte c;

declare variables in INT(INT0_vect)

     UWord min, max;

SCHEDULER.c

missed some stuff due to not correcting the copy paste stuff

add variables UByte tkHi, tkLo;

in schedule(...) near line 73 the for loops were missing the closing bracket '}'

also closing bracket for second for loop.

The variable name in the second for loop should be cylCt (copy paset error)

...and for some reason when writing a C program it is necessary to have a main function, but I didn't really provide one.

#include "types.h"
void initIgn(void);
void initA2D(void);
void initLatches(void);
void initTimers(void);
void initUart(void);
int main(void) {
 initA2D();
 initLatches();
 initTimers();
 initUart();
 initIgn();
 forever { }
 return 0;
}

Something will go in the forever loop, in a bit, or you can plug in your own ideas in the meantime.

(sloppy) Jack

My favorite word errata.  I had the chance to compile the code, and found a few "undocumented features" (bugs) in what I posted. The good news is half the files are clean.

A2D.c

EEPROM.c

LATCHES.c

and UART.c

The main issue with stuff was undeclared variables and constants, so start at the top.

types.h

line 71 should be DEG_PER_REV not DEGS_PER_REV

line 73-75 should be declared as long so add an 'L' to the end of the numbers

...additions.  Because the variables are shared globally for now, need to add to the extern list

extern UByte tkHi, tkLo;

extern UByte cylCt;

extern UWord tkEv[];

extern UWord tkSt[];

TIMERS.c

Like I said, setTach needed to be defined, so make a call to access one of the latches.

void setLatch(UByte, bool);

void setTach(bool t) { setLatch(23, t); }

IGNCRKCAM.c

This one had a lot of things missing, mostly What I think of as loop closing stuff.

add line #define FIVE_DEG  466

add prototype SLong getTime1(void);

line 34: correct spelling SLong camTime not SLong camTIme

add some variables

     UByte cylCt;

     UWord tkEv[8];

     UWord tkSt[8];

add a switch detection for cam detected

     UByte camDet = 0;

     bool isCamDet(void) { return (camDet != 0); }

     void setCamDet(bool t) { camDet = t ? 1 : 0; }

line 50 remove toothAfterCam = 0; (just used for first example).

declare variable in rtUpdateIgn routine

     UByte c;

declare variables in INT(INT0_vect)

     UWord min, max;

SCHEDULER.c

missed some stuff due to not correcting the copy paste stuff

add variables UByte tkHi, tkLo;

in schedule(...) near line 73 the for loops were missing the closing bracket '}'

also closing bracket for second for loop.

The variable name in the second for loop should be cylCt (copy paset error)

...and for some reason when writing a C program it is necessary to have a main function, but I didn't really provide one.

#include "types.h"
void initIgn(void);
void initA2D(void);
void initLatches(void);
void initTimers(void);
void initUart(void);
int main(void) {
 initA2D();
 initLatches();
 initTimers();
 initUart();
 initIgn();
 forever { }
 return 0;
}

Something will go in the forever loop, in a bit, or you can plug in your own ideas in the meantime.

(sloppy) Jack

Always one more thing... In the 1mS timer operation there needs to be calls to update the A/Ds and invoke the ignition, both are the rtUpdate routines

rtUpdateA2D();

rtUpdateIgn();

Jack