game showbuzzer

ok added risistors to reset

looks like 3 buttons work now

and 2 faulty keystone connectors are the problem now

so thanks for now the reset button NOW WORKS EXCELLENT

and when i get time ill do the 2 faulty keystones

BUT 3 IS GOOD FOR NOW

thanks

sluga

To insert code ... paste it in, then highlight it and select the >> on the menu.

Select Syntax Highlighting and then C++.

//This code was written by Bob Clagett for I Like To Make Stuff - 2016
//It accompanies the project at http://www.iliketomakestuff.com/make-quiz-game-buttons
//This is for a simple 4 player quiz game setup.
//Only one button will light at a time, until the reset button is pressed.
//The reset button turns off all LEDs and sets everything up for the next "round".

///Define Buttons
//Reset Button
int resetButtonPin = 2;

//Button1
int button1Pin = 13;
int led1Pin = 12;
int button1State = 0; 

//Button2
int button2Pin = 11;
int led2Pin = 10;
int button2State = 0; 

//Button3
int button3Pin = 9;
int led3Pin = 8;
int button3State = 0; 

//Button4
int button4Pin = 7;
int led4Pin = 6;
int button4State = 0; 

int resetButtonState = 0;
boolean pollingForPresses = 1;

int lastbutton1State = LOW;
int lastbutton2State = LOW;
int lastbutton3State = LOW;
int lastbutton4State = LOW;
int lastResetState = LOW;

void setup() {
  Serial.begin(9600);
  // initialize the LED pin as an output:
  pinMode(led1Pin, OUTPUT);
  pinMode(led2Pin, OUTPUT);
  pinMode(led3Pin, OUTPUT);
  pinMode(led4Pin, OUTPUT);
  // initialize the pushbutton pin as an input:
  pinMode(resetButtonPin, INPUT);
  pinMode(button1Pin, INPUT);
  pinMode(button2Pin, INPUT);
  pinMode(button3Pin, INPUT);
  pinMode(button4Pin, INPUT);
}

void loop() {

  int reading1 = digitalRead(button1Pin);
  int reading2 = digitalRead(button2Pin);
  int reading3 = digitalRead(button3Pin);
  int reading4 = digitalRead(button4Pin);
  int readingReset = digitalRead(resetButtonPin);

    if(pollingForPresses==1){
      //Button 1
      if (reading1 != button1State && reading1 != lastbutton1State) {
        button1State = reading1;
        button1State = digitalRead(button1Pin);
          
              if (button1State == HIGH) {
                // turn LED on:
                  Serial.print("Button 1 ON");
                digitalWrite(led1Pin, HIGH);
                pollingForPresses = 0;
              }
         button1State = 0;
      }
   
      //Button 2
      if (reading2 != button2State && reading2 != lastbutton2State) {
        button2State = reading2;
        button2State = digitalRead(button2Pin);
          
              if (button2State == HIGH) {
                // turn LED on:
                  Serial.print("Button 2 ON");
                digitalWrite(led2Pin, HIGH);
                pollingForPresses = 0;
              }
         button2State = 0;
      }

      //Button 3
      if (reading3 != button3State && reading3 != lastbutton3State) {
        button3State = reading3;
        button3State = digitalRead(button3Pin);
          
              if (button3State == HIGH) {
                // turn LED on:
                  Serial.print("Button 3 ON");
                digitalWrite(led3Pin, HIGH);
                pollingForPresses = 0;
              }
         button3State = 0;
      }

      //Button 4
      if (reading4 != button4State && reading4 != lastbutton4State) {
        button4State = reading4;
        button4State = digitalRead(button4Pin);
          
              if (button4State == HIGH) {
                // turn LED on:
                  Serial.print("Button 4 ON");
                digitalWrite(led4Pin, HIGH);
                pollingForPresses = 0;
              }
         button4State = 0;
      }
      
    }
   //Check reset button
   
    if (pollingForPresses==0) {
    
      if (readingReset != resetButtonState && readingReset != lastResetState) {
              resetButtonState = digitalRead(resetButtonPin);
          
              if (resetButtonState == HIGH) {
                Serial.print("Reset button HIGH");
                resetButtons();
              }
         
         resetButtonState = 0;
      }
    }
  lastResetState = readingReset;
  lastbutton1State = reading1;  
  lastbutton2State = reading2;
  lastbutton3State = reading3;  
  lastbutton4State = reading4;
}


void resetButtons() {
  
  lastbutton1State = 0;
  lastbutton2State = 0;
  lastbutton3State = 0;
  lastbutton4State = 0;
  resetButtonState = 0;
  lastResetState = 0;
  
  button1State = 0;
  button2State = 0;
  button3State = 0;
  button4State = 0;
  
  Serial.print("All the Buttons where reset!");
  
  digitalWrite(led1Pin, LOW);
  digitalWrite(led2Pin, LOW);
  digitalWrite(led3Pin, LOW);
  digitalWrite(led4Pin, LOW);
  digitalWrite(resetButtonPin, LOW);
  
  pollingForPresses = 1;
}

The first issue is Pin13 is normally the one with an onboard LED.

Using it as button1 will cause issues.

I'd suggest swapping the LED and the button.

I was wrong about the internal pull down resistor ... sorry.

The Atmel328 has 50k pullups internally.

If your bttons are connected to a common point, you could change this from +5v and make it ground.

You'd need to enable the pull-ups and invert the code at lines like this if (button1State == HIGH) to if (button1State == LOW)

Sorry if I got your hopes up. I always have buttons between the pin and ground.

Mark

added it to question

it would be great if i could add solution through cod as ive mounted it in box damn but i can always pull it out its only mouneted lightly

can attach the buzzer code if needed

That would be helpful.

The Inputs either need a pullup, or pulldown resistor externally, OR you can define it in the software under setup().

Mark

It is a little difficult to determine the setup by looking at the breadboard.  The resistors all seem to be floating (not connected).  Do you have a schematic of your setup?  The reset almost sounds more like an antenna than a switch.  Is it possible that you do not have a pull-up or pull-down resistor on the reset line (depending on the polarity of the reset line)?

Gene

If you already have a 1.3K resistor pull down on the arduino input, try also putting a .22uf cap between arduino input and ground.