Error in sketch code

Hi JohnC.  Good attempt.  In respect to the current limits of each I/O pin,  I would suggest the need to multiplex the LEDs (only one on at a time.)  As a more correct example:

void setup(){

ledMode(led1, OUTPUT);

ledMode(led2, INPUT);   // look up about writing a 1 to the input pin to put it in high impedance mode.

ledMode(led3, INPUT);

ledMode(led4, INPUT);   // it was stated that pinMode is preferred;  I don't know

ledMode(led5, INPUT);   // and don't want to look it up right now.  sorry. 

ledMode(led6, INPUT);

ledMode(led7, OUTPUT);   //  this is the source of one of your errors  led7,

}

void loop(){

seconds++;

while(1){

   if (seconds == 1){

      digitalWrite(led1, HIGH);

      digitalWrite(led7, LOW);

      delay(10);

      digitalWrite(led7, HIGH);    //  in theory this will probably work

                                                 // use at your own risk since it is being adapted from PIC techniques

      delay(10);

      }  // fi     * really?  I am the first to note/share this technique

         //                  of marking what this closing brace matches  !?!

...

if (timeToUpdateDisplay) break;

}  // elihw     * ditto

}  // pool       * ICNBI

Thanks billabott,

When it comes to the actual BCD clock code it will have to have more than 1 led on at a time so I'm not sure how that would work with multiplexing. 

You say that ledMode(led7, OUTPUT); is the problem but I don't see what the problem is?  It is writen the same as all of the other ledMode statements.

Should I be using pinMode() rather than ledMode()?

I was also wondering if it would be better to use the switch statement rather than multiple if statements?

John,

  Yes, it's almost always better to use a switch statement than a long

list of if statements that test consecutive values like you have.

Ok,  that's great!  I'll change them to the switch statement and see how that works.

In my code, should I have used the pinMode() statement rather than ledMode() statement?

Thanks for your help and patience.

John,

  Yes, I believe pinMode() is what you want.

(also be sure to remember the break statement in each branch

of the switch statement).

I would also note that sometimes there is a better way than

a switch statement.  If all the branches of a switch statement

are similar, or if they are all computing the value of the same

variable, it may be better to use a table lookup rather than a

switch statement.  This doesn't seem to apply in your example,

but it may be helpful in the future.

JohnC,

Couple of things since you are not using a MAX7219EWGMAX7219EWG or the like, which is what most 'Duino projects will tell you to use.  I happen to have a bag of 10 of those ICs in front of me today.  To drive the LEDs the ATMEGA328 has to do all the work that the display driver chip would normally do.  You can do this without the driver chip or over heating the UNO due to excess current demands thanks to an effect called Persistance of Vision.  Have you seen those spinning LED sticks on a bicycle wheel spoke that make readable displays by turning the LEDs on and off in a controlled sequence?  Check on YouTube if you need to.

You may want to familiarize yourself with the barGraph.pde example in the IDE and its tutorial on arduino.cc.

The way I envision it is that the loop() does the following things:

1. determine/acquire the digit values to be displayed,

2. configures the pins that are required to be ON,

3. go into a loop turning the I/O pins on and off in sequence to provide the appropriate display on the output.

Item #3 is were a switch statements would be of use.   An interrupt (or conditional break;) upon new data available would allow the execution sequence to escape from the while(1) code block and the new digit values to be processed.  I assume you are going for a clock type output display  and that is what will cause multiple switch statements within the while(1) code block.  There are many choices to make about how best to arrange the process so it runs efficiently with the goal to minimize observable flicker.  If you don't like the nesting of code blocks then move the while(1) block into a new void DisplayDigits() function and call it.  Your choice.

PS  When you want to make your project more permanent after the bugs are worked out, I recommend using strip board.

JohnC,

Couple of things since you are not using a MAX7219EWGMAX7219EWG or the like, which is what most 'Duino projects will tell you to use.  I happen to have a bag of 10 of those ICs in front of me today.  To drive the LEDs the ATMEGA328 has to do all the work that the display driver chip would normally do.  You can do this without the driver chip or over heating the UNO due to excess current demands thanks to an effect called Persistance of Vision.  Have you seen those spinning LED sticks on a bicycle wheel spoke that make readable displays by turning the LEDs on and off in a controlled sequence?  Check on YouTube if you need to.

You may want to familiarize yourself with the barGraph.pde example in the IDE and its tutorial on arduino.cc.

The way I envision it is that the loop() does the following things:

1. determine/acquire the digit values to be displayed,

2. configures the pins that are required to be ON,

3. go into a loop turning the I/O pins on and off in sequence to provide the appropriate display on the output.

Item #3 is were a switch statements would be of use.   An interrupt (or conditional break;) upon new data available would allow the execution sequence to escape from the while(1) code block and the new digit values to be processed.  I assume you are going for a clock type output display  and that is what will cause multiple switch statements within the while(1) code block.  There are many choices to make about how best to arrange the process so it runs efficiently with the goal to minimize observable flicker.  If you don't like the nesting of code blocks then move the while(1) block into a new void DisplayDigits() function and call it.  Your choice.

PS  When you want to make your project more permanent after the bugs are worked out, I recommend using strip board.

FYI

ArduinoX: IDE for Arduino

ArduinoX (pending a better name) is an alternative IDE for Arduino. It focuses on having a better out of the box experience than the standard IDE. It is more attractive, easier to use, and has better support for 3rd party boards.

ArduinoX is still very alpha, but it can edit, compile, and download to several standard boards already.

Current features include:

• new code editor with line numbers, better color scheme, anti-aliasing, and a better default font   
• !!!  I can't wait until everyone is using it.

-=SyntaxMatters=-     

Thanks billabott,

I grabbed the code for that bargraph.pde and will take a look at it.  I did, in fact, notice the line counter at the bottom left and I have downloaded the ArduinoX IDE that you recommended.  I will install it tomorrow.  As I mentioned in my reply to Coder27, now that I have fugured out how to get these LEDs working in proper sequence, I am going to move it over to my ArduinoMega2560.

Before going too far with it though, I am going to see if there is a way to shorten the code a bit. I'm sure that since I am just learning to coding in 'C', my sketch is probably larger than an experienced 'C' programmer would have.

Thanks for all your help billabott, much appreciated.

You are welcome.  You seem to be adapting and advancing quite quickly.  Feel free to read my blog  "BP 0x0004".

Thanks billabott,

I find that choosing a project and actually trying to get it to work is a lot easier for me to learn rather than just reading a book.  Books and tutorials are very helpful of course, but hands-on gets your mind working and understanding it better.  I'm going to make a number of errors along the way but that's part of the learning process,... as long as you learn from your mistakes.    Certainly having some experienced people here on Element14 who are so willing to take the time and patience to help others is priceless.

Merry Christmas to you and yours from my house.