NRF24L01 Problem simplifying code

Hello Bill,

Please can you put here the parts of code that you have in mind to break and simplify  ? Maybe that there is some parts global that should be replaced in a different way.

Thank you. Enrico

Hello Bill,

Please can you put here the parts of code that you have in mind to break and simplify  ? Maybe that there is some parts global that should be replaced in a different way.

Thank you. Enrico

Thanks for the reply, here is a section of the code with my problems;

I have added  my confusion in bold text after the lines giving me problems. there  are others but if I can understand these areas, maybe I can proceed...

Thanks for your help

Bill

void loop(void)
{
  //
  // Ping out role.  Repeatedly send the current time
  //

  if (role == role_ping_out)
  {
    // First, stop listening so we can talk.
    radio.stopListening();
     // this is the data to be sent
    // Take the time, and send it.  This will block until complete
    unsigned long time = millis();
    printf("Now sending %lu...",time);                                                                
    bool ok = radio.write( &time, sizeof(unsigned long) );         // this is writing ok but if  change  anything to

                                                                                                //write my data ( 4bytes) it wont compile...    

   if (ok)
      printf("ok...");
    else
      printf("failed.\n\r");

    // Now, continue listening
    radio.startListening();

    // Wait here until we get a response, or timeout (250ms)
    unsigned long started_waiting_at = millis();
    bool timeout = false;
    while ( ! radio.available() && ! timeout )         // I think this says " while the radio is available, and not

                                                                           //  timeout,
      if (millis() - started_waiting_at > 200 )          // if I have been waiting longer than 200 uS we have a timeout

                                                                           // with no response
        timeout = true;                                           // if all the above then we have timeout and then we will print

                                                                          //"failed etc as below.

    // Describe the results
    if ( timeout )
    {
      printf("Failed, response timed out.\n\r");
    }
    else                                                                                                   // if not timed out, get data from receiver

                                                                                                               // buffer
    {
      // Grab the response, compare, and send to debugging spew        //  what does spew mean ?

     unsigned long got_time;                                                                    // its this creating "got_time" ?       

      // Spew it
      radio.read( &got_time, sizeof(unsigned long) );                             // If I try to use my data here, instead

                                                                                                             // of " &got_time, sizeof(unsigned long)

                                                                                                              // it wont complile.

      // Spew it
      printf("Got response %lu, round-trip delay: %lu\n\r",got_time,millis()-got_time);
    }

    // Try again 1s later
    delay(1000);
  }

  //
  // Pong back role.  Receive each packet, dump it out, and send it back
  //

  if ( role == role_pong_back )
  {
    // if there is data ready
    if ( radio.available() )
    {
      // Dump the payloads until we've gotten everything
      unsigned long got_time;
      bool done = false;
      while (!done)
      {
        // Fetch the payload, and see if this was the last one.
        done = radio.read( &got_time, sizeof(unsigned long) );         // I don't  understand all after ..radio.read(...

        // Spew it
        printf("Got payload %lu...",got_time);

// Delay just a little bit to let the other unit
// make the transition to receiver
delay(20);
      }

      // First, stop listening so we can talk
      radio.stopListening();

      // Send the final one back.
      radio.write( &got_time, sizeof(unsigned long) );
      printf("Sent response.\n\r");

      // Now, resume listening so we catch the next packets.
      radio.startListening();
    }
  }

  //
  // Change roles
  //

  if ( Serial.available() )
  {
    char c = toupper(Serial.read());                                             //What is "toupper" ?
    if ( c == 'T' && role == role_pong_back )
    {
      printf("*** CHANGING TO TRANSMIT ROLE -- PRESS 'R' TO SWITCH BACK\n\r");

      // Become the primary transmitter (ping out)
      role = role_ping_out;
      radio.openWritingPipe(pipes[0]);
      radio.openReadingPipe(1,pipes[1]);
    }
    else if ( c == 'R' && role == role_ping_out )
    {
      printf("*** CHANGING TO RECEIVE ROLE -- PRESS 'T' TO SWITCH BACK\n\r");
     
      // Become the primary receiver (pong back)
      role = role_pong_back;
      radio.openWritingPipe(pipes[1]);
      radio.openReadingPipe(1,pipes[0]);
    }
  }
}

Bill, please in future insert the code with the syntax highlighting so it is more readable and easier to manage (i.e. try to insert in some editor locally).

Then also report the compilation errors (the full compilation output where the errors are explained - bad -)

    bool ok = radio.write( &time, sizeof(unsigned long) );        // this is writing ok but if  change  anything to

                                                                                                //write my data ( 4bytes) it wont compile...

IMO the definition while reading is wrong. Define it then make the operation. It is inside a loop and the defined variables exists just from where they are defined to the more internal parts of the code. If you have not problems of memory, define the boolean ok with another non-misunderstandable name (e.g. my_Ok) outside the loop as global then initialise it in the setup with the correct value you expect initially (true or false) then use it with the read operation in the loop as you are doing.

while ( ! radio.available() && ! timeout )        // I think this says " while the radio is available, and not

                                                                          //  timeout,

You check the negate value for both, so it says "while the radio is NOT available AND NOT timeout" that seems generating a never available condition.

radio.read( &got_time, sizeof(unsigned long) );                            // If I try to use my data here, instead

                                                                                                            // of " &got_time, sizeof(unsigned long)

// it wont complile.

Please show how you are using your data here, to have an idea why it does not compile.

'toupper()' usage

To be sure that all data in both sides are always checked correctly ignoring the uppercase/lowercase case, despite what is the input string (e.g. all lower case, all uppercase or mixed) the call to toupper forces all the characters to uppercase so the conditions are always checked with the right characters.

Enrico

Thank you:

I don't know how to highlight syntax. could you explain?

I will try to re-submit the question correctly.

Thank you for toupper  I should have recognized that it meant "To Upper Case".

Bill

Hi Bill,

The following image shows how to catch the syntax highlighting in the editor

Enrico

I found how to use highlighting. Thanks for the advice.

Bill,

I suggest you that you set useful answer or correct answer to the post that was correct and helped you to solve the problem, instead of assumed answered the question.

Enrico