My first switch statement

Hi Dan,

Remove the semicolon from this line:

     switch(range);

Having that ; there ends that switch statement, after which the rest gets a whole new meaning to the compiler.

Hope that helps!

Cheers,

-Nico

edit:

ps, "state==1, flasha;" is not valid syntax either...

maybe you meant something like this?

switch (range) {

     case 0:

          state = 1;

          function1();

     break;

     case 1:

          state = 2;

          function2();

     break;

}

Hey Dan & Nico.

Looking at http://www.arduino.cc/en/Tutorial/SwitchCase

Would not the range value be determined before entering the  switch(range)&case structure?

I guess you could set it up that for case 0:  to cause the count from the button press(es) to modify the range value and as long that is contained in the main loop() function.  If you do it that way then the other cases would need to reset the range to 0 as the last step within each case #: segment (ie before the break statements;  but not in the case 0: segment).  Then again there may be some rule in the complier that stops the range value from being modified inside the case structure.   This would not be the standard way to do this anyway.   Would be much better to determine the number of button presses, store it in the range variable, and then execute the case statement.   

Dan,  please create a setup();  a loop(), and a flasha()  which will all be of type void unless they return() a value.       Declare your global variables above the setup() and after the #include file.  

Hi Billabot,

Yes, the value for range must definitely be set before entering the switch, as the switch depends on the value of range.

I assumed Dan had posted just a snippet of his code.

Great example in your picture!

Cheers,

-Nico

Hi Guys,

Frist thanks for all your help, gave me alot to think about.  I have made some progress but it is still not working wright.  So far this is what I have.

int state=8;

int mi=9;

int lastState=LOW;

int lastbutton=LOW;

int countmi=0;

int countst=0;

int button=LOW;

int buttonst=LOW;

void setup()

{// open void setup

Serial.begin(9600);

pinMode(state, INPUT);//set pin 8

pinMode(mi, INPUT);//set pin 9

state=digitalRead(8);

button=digitalRead(9);

}//close void setup

void loop()

{//open void loop

if (buttonst==HIGH && lastState==LOW)

    {//open state count

    countst++; 

    if (buttonst==10)

    { buttonst==0;

    Serial.println(countst);

    Serial.print("state =");                      

    }//closes state count

     Serial.print(buttonst); 

           {// open switch

            int range;

            int  flasha;

            int  flashb;

            switch(range)

                   {//open case

                     case 0:

                     buttonst=0;

                     flasha;

                     break;

                     case 1:

                     buttonst=2;

                     flashb;

                     break;

                    }// close case

          }//close switch

    lastState=buttonst;

    buttonst=digitalRead(8);

    if (button==HIGH && lastbutton==LOW)

        {// open mi count

        countmi++;

        Serial.println(countmi);

        }//close mi count

    lastbutton=button;

    button=digitalRead(9);

}//close void loop

  {//open flasha

    int flasha;

    Serial.println("Hellow world");

delay (1000);

  }//close flasha

  {// open flashb

    int flashb;

    Serial.println("Not gonna happen");

  }}//close flashb

When you run it and open your Serial Monitor this is what happens.

It will print

Hello World

delay

then it prints

Not gonna happen

it does this over and over.  I think my problem is it is not polling my switch statements.  I think it is just going to the ends where I have my subroutines.  The worst part about this is it does it automatically.  Thats right you dont need to make a circuit.  Just cut and paste it and you will see what I mean.

Please help before I choke someone out.

Thanks

Hi Dan,

You are not defining and calling your functions correctly.

Remove these two lines, as they define them as integers, which is not the intention:

            int  flasha;

            int  flashb;

In the switch statement, change how you call the functions - they need opening and closing parentheses to show that it is a function call:

            switch(range)

                   {//open case

                     case 0:

                     buttonst=0;

                     flasha();

                     break;

                     case 1:

                     buttonst=2;

                     flashb();

                     break;

                    }// close case

And to define your functions you need to give them names and identify what they give back (the first void) and what they receive (the second void)...

void flasha(void)

  {//open flasha

    int flasha;

    Serial.println("Hellow world");

delay (1000);

  }//close flasha

void flashb(void)

  {// open flashb

    int flashb;

    Serial.println("Not gonna happen");

  }}//close flashb

I haven't really looked at what the rest is doing or should be doing, but this will get you on your way.

Cheers,

-Nico

Ok Nico

I tried your changes.  Now when I go to compile I get the error 'flasha' was not declared in this scope  it is highlighting this section

   switch(range)

                   {//open case

                     case 0:

                     buttonst=0;

                     flasha();

                     break;

                     case 1:

                     buttonst=2;

                     flashb();

                     break;

                    }// close case

one of the big problems I am having is I dont understand what these errors are talking about.  Is there a place I can go to that will expalin what this means?

To arrive HERE

One must first go HERE and do THIS:

-=Syntax Matters=-

Here's a good link too: http://diyroboticslab.wordpress.com/2009/06/04/ledblink-arduino-program/

It goes into the C programming language, and also has links to what error messages mean.

Thanks for all the help.  Just made a big improvement and I almost got it working.  There are only 2 problems now.  1 I have to hold the button down for about 2 or 3 seconds for it to switch subroutines.  I can deal with that but can I speed it up?  2. I made a note called "RIGHT HERE" I try to reset they count to 0.  It just keeps counting.  What did I do wrong?

int state=8;

int mi=9;

int lastState=LOW;

int lastbutton=LOW;

int countmi=0;

int countst=0;

int button=LOW;

int buttonst=LOW;

void setup()

{// open void setup

Serial.begin(9600);

pinMode(state, INPUT);//set pin 8

pinMode(mi, INPUT);//set pin 9

state=digitalRead(8);

button=digitalRead(9);

}//close void setup

void loop()

{//open void loop

if (buttonst==HIGH)

    {//open state count

    if (buttonst==10)buttonst==0;                    RIGHT HERE

     countst++;

    Serial.println(countst);

    Serial.print("state =");                      

    }//closes state count

  //   Serial.print(buttonst); 

           {// open switch

            switch(countst)

                   {//open case

                     case 0:

                     buttonst=0;

                     flasha();

                     break;

                     case 1:

                     buttonst=2;

                     flashb();

                     break;

                      case 2:

                     buttonst=3;

                     flashc();

                     break;

                    }// close case

          }//close switch

    lastState=buttonst;

    buttonst=digitalRead(8);

    if (button==HIGH && lastbutton==LOW)

        {// open mi count

        countmi++;

        Serial.println(countmi);

        }//close mi count

    lastbutton=button;

    button=digitalRead(9);

}//close void loop

  //open flasha

    void flasha()

    {

    int flasha;

    Serial.println("Hellow world");

delay (1000);

  }//close flasha

  void flashb()

  {// open flashb

    int flashb;

    delay(1000);

    Serial.println("Not gonna happen");

  }//close flashb

  void flashc()

  {

    int flashc;

    delay(1000);

    Serial.println("I did it");

  }

verses

// you need a whole bunch more comments

// so you can remember how it is supposed to work