more Arduino silliness.

Hi phoenixcomm ,

As shabaz pointed out, RST_1 is double defined, but in addition, if this is all in the .h file, then you shouldn't have the pinMode calls directly there.

If the goal is to shorten the calls into a define, you'd have to #define it the same way, something like:
#define SETUP_RST_1 pinMode(RST_1, OUTPUT)

and then in setup() you'd call it as follows:

setup() {
   SETUP_RST_1;
}

However, I don't think that really cleans up your setup() function much, and it's a bit hokey. And you end up typing more stuff overall.
I would recommend not using #define for that purpose. Maybe use a second C file to hold the setup commands? Or just put those pinMode functions down lower in the main sketch file in a separate function. Then your setup function would look more like:

setup() {
   setup_all_pins();
}

(I also recommend a better name - one that matches the purpose of those pins a bit better.)

If you like even cleaner code, I think object oriented might be worth a look. Encapsulate all the functionality of a given thing into a separate file, and then from the main file just initialize it and call functions on it that do only what you need in the main sketch.

For example, consider my thermistors sample. The attached zip file contains the sketch (for a Wemos D1 Mini), with the Thermistor object.
I keep the thermistor object in the separate Thermistor.cpp and Thermistor.h files, and in the main sketch I just set up each thermistor with a single line as follows:

            //    pin, R_nom, Nom_temp, Beta, divider_resistor
Thermistor therm6(A0, 5000, 25.0, 3892, 10000);

And to grab the temperature in the loop() of the sketch, it’s also just one line:
   float temp6 = therm6.getTemperature();

And it’s easy to repeat as often as you like - each is a separate object that takes care of its own variables, its own setup, its own pin handling, its own math... so you don’t even have to keep all of that straight in your main sketch - ie, no arrays of numbers upon arrays of numbers for all of their settings. No carrying of extra functions to do all the thermistor-specific math. Once you have the object built and tested, the rest is just neatly tucked out of sight. And reusability becomes trivial - just copy and paste the object files.

Hi phoenixcomm ,

As shabaz pointed out, RST_1 is double defined, but in addition, if this is all in the .h file, then you shouldn't have the pinMode calls directly there.

If the goal is to shorten the calls into a define, you'd have to #define it the same way, something like:
#define SETUP_RST_1 pinMode(RST_1, OUTPUT)

and then in setup() you'd call it as follows:

setup() {
   SETUP_RST_1;
}

However, I don't think that really cleans up your setup() function much, and it's a bit hokey. And you end up typing more stuff overall.
I would recommend not using #define for that purpose. Maybe use a second C file to hold the setup commands? Or just put those pinMode functions down lower in the main sketch file in a separate function. Then your setup function would look more like:

setup() {
   setup_all_pins();
}

(I also recommend a better name - one that matches the purpose of those pins a bit better.)

If you like even cleaner code, I think object oriented might be worth a look. Encapsulate all the functionality of a given thing into a separate file, and then from the main file just initialize it and call functions on it that do only what you need in the main sketch.

For example, consider my thermistors sample. The attached zip file contains the sketch (for a Wemos D1 Mini), with the Thermistor object.
I keep the thermistor object in the separate Thermistor.cpp and Thermistor.h files, and in the main sketch I just set up each thermistor with a single line as follows:

            //    pin, R_nom, Nom_temp, Beta, divider_resistor
Thermistor therm6(A0, 5000, 25.0, 3892, 10000);

And to grab the temperature in the loop() of the sketch, it’s also just one line:
   float temp6 = therm6.getTemperature();

And it’s easy to repeat as often as you like - each is a separate object that takes care of its own variables, its own setup, its own pin handling, its own math... so you don’t even have to keep all of that straight in your main sketch - ie, no arrays of numbers upon arrays of numbers for all of their settings. No carrying of extra functions to do all the thermistor-specific math. Once you have the object built and tested, the rest is just neatly tucked out of sight. And reusability becomes trivial - just copy and paste the object files.