element14 Community
element14 Community
    Register Log In
  • Site
  • Search
  • Log In Register
  • About Us
  • Community Hub
    Community Hub
    • What's New on element14
    • Feedback and Support
    • Benefits of Membership
    • Personal Blogs
    • Members Area
    • Achievement Levels
  • Learn
    Learn
    • Ask an Expert
    • eBooks
    • element14 presents
    • Learning Center
    • Tech Spotlight
    • STEM Academy
    • Webinars, Training and Events
    • Learning Groups
  • Technologies
    Technologies
    • 3D Printing
    • FPGA
    • Industrial Automation
    • Internet of Things
    • Power & Energy
    • Sensors
    • Technology Groups
  • Challenges & Projects
    Challenges & Projects
    • Design Challenges
    • element14 presents Projects
    • Project14
    • Arduino Projects
    • Raspberry Pi Projects
    • Project Groups
  • Products
    Products
    • Arduino
    • Avnet Boards Community
    • Dev Tools
    • Manufacturers
    • Multicomp Pro
    • Product Groups
    • Raspberry Pi
    • RoadTests & Reviews
  • Store
    Store
    • Visit Your Store
    • Choose another store...
      • Europe
      •  Austria (German)
      •  Belgium (Dutch, French)
      •  Bulgaria (Bulgarian)
      •  Czech Republic (Czech)
      •  Denmark (Danish)
      •  Estonia (Estonian)
      •  Finland (Finnish)
      •  France (French)
      •  Germany (German)
      •  Hungary (Hungarian)
      •  Ireland
      •  Israel
      •  Italy (Italian)
      •  Latvia (Latvian)
      •  
      •  Lithuania (Lithuanian)
      •  Netherlands (Dutch)
      •  Norway (Norwegian)
      •  Poland (Polish)
      •  Portugal (Portuguese)
      •  Romania (Romanian)
      •  Russia (Russian)
      •  Slovakia (Slovak)
      •  Slovenia (Slovenian)
      •  Spain (Spanish)
      •  Sweden (Swedish)
      •  Switzerland(German, French)
      •  Turkey (Turkish)
      •  United Kingdom
      • Asia Pacific
      •  Australia
      •  China
      •  Hong Kong
      •  India
      •  Korea (Korean)
      •  Malaysia
      •  New Zealand
      •  Philippines
      •  Singapore
      •  Taiwan
      •  Thailand (Thai)
      • Americas
      •  Brazil (Portuguese)
      •  Canada
      •  Mexico (Spanish)
      •  United States
      Can't find the country/region you're looking for? Visit our export site or find a local distributor.
  • Translate
  • Profile
  • Settings
Arduino
  • Products
  • More
Arduino
Arduino Forum Coding with else{}...what are the cost benefits analysis?
  • Blog
  • Forum
  • Documents
  • Quiz
  • Events
  • Polls
  • Files
  • Members
  • Mentions
  • Sub-Groups
  • Tags
  • More
  • Cancel
  • New
Join Arduino to participate - click to join for free!
Actions
  • Share
  • More
  • Cancel
Forum Thread Details
  • Replies 15 replies
  • Subscribers 387 subscribers
  • Views 2823 views
  • Users 0 members are here
  • arduino_code
  • arduino
Related

Coding with else{}...what are the cost benefits analysis?

colporteur
colporteur over 2 years ago

if (digitalRead(ButtonPin) == LOW) {  //}

OR

if (digitalRead(ButtonPin) == HIGH) {  //
  return HIGH;
} else {  //}

I came across these two methods of testing a button. They both accomplish the same thing. 

Why would a coder use one over the other? What are advantages/disadvantages to using either?

I am a code resurrectionist not a programmer or coder. I usually cut and paste code parts to develop a working project. I have code that use both methods. I'm curious what falls into best practice? Does one provide better performance?

  • Sign in to reply
  • Cancel

Top Replies

  • shabaz
    shabaz over 2 years ago +4
    Hi Sean, There's not much difference, one might be a fraction faster or slower but it's negligible. It also depends on if the push-button is wired to ground or to the supply. Everyone does it in different…
  • javagoza
    javagoza over 2 years ago +4
    If it is a button I try not to read and compare the state in the if statement but to compare against a state variable of the button. In this way I can add logic to prevent button click bounces or have…
  • Fred27
    Fred27 over 2 years ago +4
    Code readability and maintainability will trump any minor performance differences in almost all cases. Make sure your code is easy to follow, debug, and extend and all will be good. Exactly what code…
Parents
  • shabaz
    shabaz over 2 years ago

    Hi Sean,

    There's not much difference, one might be a fraction faster or slower but it's negligible. It also depends on if the push-button is wired to ground or to the supply.

    Everyone does it in different ways, personally I just bury that detail in the #define section, approximately like this:

    //****** Definitions ******
    #define BUTTON_PIN 10
    #define BUTTON_PRESSED (digitalRead(BUTTON_PIN)==LOW)
    #define BUTTON_UNPRESSED (digitalRead(BUTTON_PIN)!=LOW)

    //****** Code ********
    if (BUTTON_PRESSED) {
    // do whatever
    }

    (Cant see the Editor toolbar, otherwise I'd format it as code!). 

    • Cancel
    • Vote Up +4 Vote Down
    • Sign in to reply
    • Cancel
Reply
  • shabaz
    shabaz over 2 years ago

    Hi Sean,

    There's not much difference, one might be a fraction faster or slower but it's negligible. It also depends on if the push-button is wired to ground or to the supply.

    Everyone does it in different ways, personally I just bury that detail in the #define section, approximately like this:

    //****** Definitions ******
    #define BUTTON_PIN 10
    #define BUTTON_PRESSED (digitalRead(BUTTON_PIN)==LOW)
    #define BUTTON_UNPRESSED (digitalRead(BUTTON_PIN)!=LOW)

    //****** Code ********
    if (BUTTON_PRESSED) {
    // do whatever
    }

    (Cant see the Editor toolbar, otherwise I'd format it as code!). 

    • Cancel
    • Vote Up +4 Vote Down
    • Sign in to reply
    • Cancel
Children
No Data
element14 Community

element14 is the first online community specifically for engineers. Connect with your peers and get expert answers to your questions.

  • Members
  • Learn
  • Technologies
  • Challenges & Projects
  • Products
  • Store
  • About Us
  • Feedback & Support
  • FAQs
  • Terms of Use
  • Privacy Policy
  • Legal and Copyright Notices
  • Sitemap
  • Cookies

An Avnet Company © 2025 Premier Farnell Limited. All Rights Reserved.

Premier Farnell Ltd, registered in England and Wales (no 00876412), registered office: Farnell House, Forge Lane, Leeds LS12 2NE.

ICP 备案号 10220084.

Follow element14

  • X
  • Facebook
  • linkedin
  • YouTube