Help with adding to my code

toxsickcity

Using someone else code is alaways tricky. You spend so much time figuring out what does waht.

Firstly

Do you have the 4k7 pullup resistor added between 5v and the data pin of the two sensors.?

Without this you won't be able to talk with the sensor, and therefore no reading.

If you open the Serial Terminal do you get either of the messages in Line 118 or 120?

I haven't tried talking to two sensors but you don't need to discover them every time you want to read the temperature. Line 112, 158

This is a sketch I did for controlling two relays using a single sensor (one was for heating the other cooling)

/*
  Temp Controlled Relay

 DS18B20 Temperature chip on pin 2
 4k7 pullup between pin 2 and +5v.

 Pin assignments
 Pin 0  Rx
 Pin 1  Tx
 Pin 2  Temp sensor DS18B20
 Pin 7  Relay 1 output (Low to make it turn ON)
 Pin 8  Relay 2 output (Low to make it turn ON)


 Created 15 Nov 2012
 by Mark Beckett

    
 */

// include the library code:

#include <OneWire.h>

// DS18B20 Temperature chip i/o
OneWire ds(2);                     // TempSensor on pin 2
byte i;
byte present = 0;
byte data[12];
byte addr[8];
word TReading;
byte HighByte, LowByte;
int SignBit, Tc_dec, Tc_100, Whole, Fract;

//inputs
const int TempSensor = 2;               // Tempsensor name

//Outputs
const int Relay1 = 7;               // Relay 1 Output
const int Relay2 = 8;               // Relay 2 Output
const int LedPin = 13;              // LED on pin 13

//Settings
int LowTempOn = 14;                   // Low Temperature On setting
int LowTempOff = 24;                  // Low Temperature Off setting
int HighTempOn = 29;                 // High Temperature On setting
int HighTempOff = 25;                // High Temperature Off setting

//-------------------------------------------------------------------------


void setup() 
{
   Serial.begin(57600);//Serial.begin(57600);
   
  //Define the pins
  pinMode(TempSensor, INPUT);
  pinMode(Relay1, OUTPUT);
  digitalWrite (Relay1, HIGH);    //Relay is OFF 
  pinMode(Relay2, OUTPUT);
  digitalWrite (Relay2, HIGH);    //Relay is OFF 
  
  !ds.search(addr);            //search for DS18B20 and identify its serial number
  Serial.println ("'The Shed' magazine Temperature Sensor example");
  Serial.println ("Refer to 2012 Dec/Jan issue for details");

}

void loop() 
{
    Whole = 0;                //reset to a known value
    Fract = 0;                //reset to a known value
    Tc_dec =0;                //reset to a known value
    
    //reset and setup the temp sensor for communicating
        ds.reset();
        ds.select(addr);
        ds.write(0x44,1);        // start a temp reading
        
        delay(1000);             // wait 1 sec for data to be present
        
        present = ds.reset();
        ds.select(addr);    
        ds.write(0xBE);          // Read Scratchpad in the temp sensor
    
      for ( i = 0; i < 9; i++)   // we need 9 bytes
      {
        data[i] = ds.read();     //read the 9 bytes of data for a temperature      
      }
      
    Serial.print("Temp = ");
      
      LowByte = data[0];                       // the first byte is the lowest
      HighByte = data[1];                      // second byte is the highest
      TReading = (HighByte << 8) + LowByte;
      SignBit = TReading & 0x8000;             // test most sig bit
      if (SignBit)                             // If its negative
      {
         TReading = (TReading ^ 0xffff) + 1;   // 2's comp 
      }
        Tc_100 = (6 * TReading) + TReading / 4;    // multiply by (100 * 0.0625) or 6.25

        Whole = Tc_100 / 100;                  // separate off the whole portions
        Fract = Tc_100 % 100;                  // separate off the fraction portions
        
        if (SignBit)                           // If its negative
        {
         Serial.print("-");
        }
       Serial.print (Whole);
       //Serial.print(".");
       // if (Fract < 10)
       // {
       //  Serial.print("0");
       // }
       // Serial.print(Fract);
       Serial.print("\n");
      
      
       //Relays are ON when the ouput pin is LOW
       if (Whole <= LowTempOn)                              //reading is below or equal to the setting
       {
         digitalWrite(Relay1,LOW);
         digitalWrite(LedPin, HIGH);
       }
       if (Whole >= LowTempOff && !digitalRead(Relay1))     //reading is above or equal to the setting and Relay1 is ON
       {
         digitalWrite(Relay1,HIGH);
         digitalWrite(LedPin, LOW);
       }
       if (Whole >= HighTempOn)                              //reading is below or equal to the setting
       {
         digitalWrite(Relay2,LOW);
         digitalWrite(LedPin, HIGH);
       }
       if (Whole <= HighTempOff && !digitalRead(Relay2))    //reading is above or equal to the setting and Relay2 is ON
       {
         digitalWrite(Relay2,HIGH);
         digitalWrite(LedPin, LOW);
       } 
       if (digitalRead(Relay1) && digitalRead(Relay2))      // Flash the LED if either relay is High (Off).
       {
         digitalWrite(LedPin,!digitalRead(LedPin));
       }
}

You can see the temperature on the serial port

Mark

Hi, Thankyou for your reply.

I do have a 4k7 on the sensors.

Currently the arduino with this code does control 2 LED Strips with 2 sensors (each sensor control 1 LED Strip).

I am very happy with that.

I want to go with additional feature using the same 2 sensors to also control the that relay board.

when I get home I will have a go at editing my code.

Lastly, Can you explain to me how to view my arduino in a terminal window.

It never works for me

I read about it, and dont know why it displays nothing!

Lastly, Can you explain to me how to view my arduino in a terminal window.

As long as you have the Serial.begin(57600)

You seem to have it twice Line 60 and 67

and some Serial.print or Serial.println somewhere it should work.

I'd add something like

     Serial.print("k :");

     Serial.println(((rgb[k] *bright[k])/256));

to line 94 and 95

     Serial.print("k2 :");

     Serial.println(((rgb2[k] *bright[k])/256));

to line 100 and 102 (or 104 and 106 as they'll become).

which should show the values that are being sent to the rgb pins.

I simply open the Serial Monitor

It will remember the last setting, so I tend to always use the same (9600) for my sketches as they are generally in debug mode and not timing critical.

Try my sketch and you should get something.

BTW Lines 59 and 66 are trying to read something on the Analogue pins ...not sure what but.

Mark

A Massive thank you for your help,

I was too tired after work last night to fiddle but after today, its the weekend!!

many thanks,

I will report my findings tonight if I have enough energy!

Hey Mark,

I got the outputs working, it reads 5v on my selected pins when the Set thermal goes over, that's for 2 channels working independently.

many thanks for your advise and your messages.

I got another request, if you have time.

I want to push my arduino board even harder and would save me a heap of space in my project if able to add another "Sensor/LED Strip/Relay Output".

To be able to do this I would need to change my system from RGB To fade Blue to Red.

This also means using only 2 not 3 PWM outputs for each LED Strip removing green which is exactly what I wanted from this project.

I never intended to have green show up during the heat changes, imo for my project.

Going from blue to green than to red looks a bit silly!!

I could use some help only if you have time.

I'll have a look, but first thought is you might be running out of PWM pins.

Pins 3,5,6,9,10 and 11 are all you get.

So in theory if you drop the green channel, you could have 3 x 2 channel Red/Blue.

You could set the green component using resistors.

As an alternative, have you considered using neoPixels (WS 2812) devices instead.

One output pin can drive hundreds individually both colour and brightness.

https://www.adafruit.com/?q=neopixel&

These are 60 LED's per meter

https://www.adafruit.com/products/1461

Mark

Hi Mark,

Those LEDs are cool!

I might have to buy some for future experiment.

I would like to stay with my current design tho,

Can you explain what you mean about the possible of keeping my green but using resistors?

I don't want to keep green but am interested in hearing how you would go about keeping green when not using the pwm output?

how you would go about keeping green when not using the pwm output

The PWM alters how much voltage the LED receives. ie at 50% it is approximately half the current.

You can use a digital Output to turn it ON or OFF and use two resistors to approximate the level you would have via a PWM output.

The two resistors form a voltage divider so the 5v outout is dropped to a differen tvoltage depending on the ratio between the two.

You need to be careful that the values aren't too high (or too low).

Do a google search on Voltage divider and there will be online calculators ...

Mark

Oh I understand, but I would have required those digital out pins, and having 3 sets of Blue/Red would mean that I cannot. because the digital pins are being used to switch relays on and where the sensor connects.

I will have the pins as such

6x PWM = LED (Blue1/Red1, Blue2/Red2, Blue3/Red3)

3x Sensor Inputs

3x Relay Trigger outputs.

so I think that is using all the digital pins on the Arduino Board.

Playing with my code, I was able to change a line that said 0000FF00 to 00000000 and it removed green completely,

but it didnt fade from blue to red nicely, it went off in between the 2 colours.

I will leave it with you so see if you can come up with anything.

Oh I understand, but I would have required those digital out pins, and having 3 sets of Blue/Red would mean that I cannot. because the digital pins are being used to switch relays on and where the sensor connects.

I will have the pins as such

6x PWM = LED (Blue1/Red1, Blue2/Red2, Blue3/Red3)

3x Sensor Inputs

3x Relay Trigger outputs.

so I think that is using all the digital pins on the Arduino Board.

Playing with my code, I was able to change a line that said 0000FF00 to 00000000 and it removed green completely,

but it didnt fade from blue to red nicely, it went off in between the 2 colours.

I will leave it with you so see if you can come up with anything.

Just a quick reply

so I think that is using all the digital pins on the Arduino Board.

The Analogue pins can also be used as Digital.

A0 = D14

A1 = D15

A2 = D16

A3 = D17

A4 = D18

A5 = D19

Mark

toxsickcity

Firstly I don't have your setup, so it's very hard to give you code that works.

All I can do is provide some pointers to help you work out what is happening.

The numbers at lines 89 and 95 (turn on line numbering under preferences)

  rgb[0] = (rgbval & 0x00FF0000) >> 16; // there must be better ways

  rgb[1] = (rgbval & 0x0000FF00) >> 8;

  rgb[2] = rgbval & 0x000000FF;

are getting a value using some maths.

The 0x signifies a hex number and if you plug it into windows calculator (macs must have an equivalent) on programmer mode you can display the binary equivalent.

(rgbval & 0x00FF0000) is an AND function, where the 24bit number held in rgbval is AND'ed with hex FF0000.

This bascially extracts the last 8 bits of the rgbval (ie the MSB 8 bits).

The >> 16 signifies shifting the result 16 places towards the decimal point.

So they start with a 24 bit number and seperate it into three 8 bit numbers.

Because you changed the FF00 into 0000 you have effectively removed the middle parts of the rgbval number, which I presume is the green .

There is a brightness setting here in line 52 (and 53 for the other set)

long bright[3] = { 107, 67, 256};

If the green LED is on pin 10, then you could try changing the 67 to something lower instead.

Original sketch

This sketch seems to add up lots of things, store as a large number then break it down to individually control the pins.

For your Red or Blue, I'm wondering if you start with a neutral colour at (20 degC), and if it's lower then increase the Blue, or hotter increase the red.

You could speed it up by stepping one up while stepping the other down to double the effect.

Hope this helps

Mark

Thanks so much for your help,

I have played with these values and yes I does change how green operates..

It is helpful but with wanted to add that 3rd set of LED strip and sensor,

I need to remove the pin usage.

Can I ask for your explanation of the following?

Line 24,  #define RED       9// pin for red LED

How does it know to use 3 pins for the pins 9, 10 and 11?

is it something with the Line 61 and 62?

  for (k=0; k<3; k++) {

    pinMode(RED + k, OUTPUT);

does K represent how many pins to use?

as I was helped with adding a 2nd set of pwm pins as the code wanted to use pins 3,4,5 for the 3,5,6 i have configured

so the code is different, it states to use pins 3,5,6 with the

Line 34 int secondPins [] = { 3,5,6};

vs Line 24 which only says  #define RED       9// pin for red LED

at this stage I only want to play with the code to see if I can remove 1 pin from each RGB strip and I will play with the colouring later..

the code system in the software is also pretty good as it kind of tells me whats wrong when I randomly remove code to trial editing hjahaha

i hope you can shed some light on this..

Thanks for your interest and help,

Would you like me to draw a schematic diagram and attach photos of the way I have it wired?

toxsickcity

Which one do I start with ....I'm at work so I don;t have full access to the IDE.

Yes basically line 61, 62 are definng the other pins.

RED (9) + k (0) = 9, then RED (9) + k (1) = 10, then RED (9) + k (2) = 11 is how it works.

K never reaches more than 2 ...

Look at the reference under For ....  basically you specify the start (0) ; Limit (K <3) K is less than 3; increment (k++) which is K + 1.

Line 34 is defining an array.

The best way is to think of a calendar. It is months [12] and for each month they have a certain number of days.

Line 34 is saying the array called secondPins[0] contains 3, secondPins[1] contains 4, and secondPins[2] contains 5.

Because you haven't said what size the array is it is happy when there is no more data.

There are some mixtures of methods used for this sketch .... which makes it harder to get your head around.

I suggest you download this book.

https://juniorfall.files.wordpress.com/2011/11/arduino-cookbook.pdf

https://github.com/shihyu/Arduino/blob/master/books/Oreilly.Arduino.Cookbook.2nd.Edition.Dec.2011.pdf

Mark