find.ulp (7.5.0) bug

On 09.12.2015 18:30, Jorge Garcia wrote:

On 12/8/2015 8:32 AM, Morten Leikvoll wrote:

Im typing "run find pad ff9" and I get the error "Multiple contacts on

pin, use contacts() instead" and cursor points to line 1138 containing

"if (P.contact) {"

 

ULP info:

// Version 2.8 2014.03.21   - corrected option -S

 

Hello Morten,

 

I hope you're doing well. I can't reproduce this on one of EAGLE's demo

files.

 

Would you be able to send me a test file? That way I(or another cadsoft

employee) can update the code in the ULP. Send it to

support@cadsoftusa.com.

 

Let me know if there's anything else I can do for you.

Thanks Jorge. I would think the error and the code alone would explain

what my design does. The ulp says the gate has several contact, but the

code expects one. This looks like something leftover from old versions,

before a pin could could have several contacts.

Ref help on UL_PIN0:

"UL_CONTACT (deprecated, see note)"

...

"The contacts() loop member loops through the contacts that have been

assigned to the pin through a CONNECT command. This is the case in a

UL_DEVICE context or coming via UL_PINREF, but not via

UL_LIBRARY.symbols(). If this is not the case the list is empty.

The contact data member returns the contact that has been assigned to

the pin through a CONNECT command. This member is deprecated! It will

work for backwards compatibility and as long as only one pad has been

connected to the pin, but will cause a runtime error when used with a

pin that is connected to more than one pad. "

So its obvious, my symbol has a pin with several pads.

On 09.12.2015 18:30, Jorge Garcia wrote:

On 12/8/2015 8:32 AM, Morten Leikvoll wrote:

Im typing "run find pad ff9" and I get the error "Multiple contacts on

pin, use contacts() instead" and cursor points to line 1138 containing

"if (P.contact) {"

 

ULP info:

// Version 2.8 2014.03.21   - corrected option -S

 

Hello Morten,

 

I hope you're doing well. I can't reproduce this on one of EAGLE's demo

files.

 

Would you be able to send me a test file? That way I(or another cadsoft

employee) can update the code in the ULP. Send it to

support@cadsoftusa.com.

 

Let me know if there's anything else I can do for you.

Thanks Jorge. I would think the error and the code alone would explain

what my design does. The ulp says the gate has several contact, but the

code expects one. This looks like something leftover from old versions,

before a pin could could have several contacts.

Ref help on UL_PIN0:

"UL_CONTACT (deprecated, see note)"

...

"The contacts() loop member loops through the contacts that have been

assigned to the pin through a CONNECT command. This is the case in a

UL_DEVICE context or coming via UL_PINREF, but not via

UL_LIBRARY.symbols(). If this is not the case the list is empty.

The contact data member returns the contact that has been assigned to

the pin through a CONNECT command. This member is deprecated! It will

work for backwards compatibility and as long as only one pad has been

connected to the pin, but will cause a runtime error when used with a

pin that is connected to more than one pad. "

So its obvious, my symbol has a pin with several pads.

Since this is a very easy fix and hasnt been fixed on 7.5.3 beta, I will

help you:

On line 1138,1139 of the original find.ulp:

1138:if (P.contact) {

1139:if (P.contact.name == Find) {

Replace this with:

1138:P.contacts(C) {

1139:if (C.name == Find) {

And this will work also with symbols having multiple pads assigned to a pin.

On 10.12.2015 09:28, Morten Leikvoll wrote:

On 09.12.2015 18:30, Jorge Garcia wrote:

On 12/8/2015 8:32 AM, Morten Leikvoll wrote:

Im typing "run find pad ff9" and I get the error "Multiple contacts on

pin, use contacts() instead" and cursor points to line 1138 containing

"if (P.contact) {"

 

ULP info:

// Version 2.8 2014.03.21   - corrected option -S

 

Hello Morten,

 

I hope you're doing well. I can't reproduce this on one of EAGLE's demo

files.

 

Would you be able to send me a test file? That way I(or another cadsoft

employee) can update the code in the ULP. Send it to

support@cadsoftusa.com.

 

Let me know if there's anything else I can do for you.

 

Thanks Jorge. I would think the error and the code alone would explain

what my design does. The ulp says the gate has several contact, but the

code expects one. This looks like something leftover from old versions,

before a pin could could have several contacts.

 

 

Ref help on UL_PIN0:

 

"UL_CONTACT (deprecated, see note)"

...

"The contacts() loop member loops through the contacts that have been

assigned to the pin through a CONNECT command. This is the case in a

UL_DEVICE context or coming via UL_PINREF, but not via

UL_LIBRARY.symbols(). If this is not the case the list is empty.

The contact data member returns the contact that has been assigned to

the pin through a CONNECT command. This member is deprecated! It will

work for backwards compatibility and as long as only one pad has been

connected to the pin, but will cause a runtime error when used with a

pin that is connected to more than one pad. "

 

So its obvious, my symbol has a pin with several pads.