Help with UPL "if plur OR "

maybe wrote:

I am modifiying an ULP that adapts all drill sizes to Olimex ones but

I want to check if the drill size is already and olimex standard.

 

So I want to check the value of "rval" against the standard values, so

have made that line ( formatting has been los a little )

 

but i get an error when running the ULP, have I made something wrong in

the

 

if.....

 

line

 

 

code fragment starts-------

 

real rval=isdrill// first we check if the drill value is an Olimex

standard, if so we do not modify it

 

if (rval!=3.3 || rval!=2.1 || rval!=1.5 || rval!=1.3 || rval!=1.1 ||

rval!=1.0 || rval!=0.9 || rval!=0.7) {

 

rval = round((isdrill+round_offset) * 10.0) / 10.0; // round value

 

}

 

 

 

 

code fragment end-------

 

Thanks in advance

Since the order of || and != could be confused it may be that adding

grouping as

if ((rval != #.#) || (...

may help

I have not looked for ULP documentation to see if != are done before ||

are at the same time.

Paul R.

but i get an error when running the ULP, have I made something wrong in

the

 

if.....

 

line

 

 

code fragment starts-------

if (rval!=3.3 || rval!=2.1 || rval!=1.5 || rval!=1.3 || rval!=1.1 ||

rval!=1.0 || rval!=0.9 || rval!=0.7) {

 

rval = round((isdrill+round_offset) * 10.0) / 10.0; // round value

code fragment end-------

 

Thanks in advance

There will always be one of those OR conditionings true so your  IF

statement always evaluates as true and so you will always do the rval =

round etc.

Warren

maybe wrote on Sat, 20 March 2010 07:20

I am modifiying an ULP that adapts all drill sizes to Olimex ones

There are many board houses out there.  Why waste time with the only one

that can't multiply by 25.4, with a uppity attitude on top of that?

Around 8 years ago I thought I'd give Olimex a try on some prototype

boards.  I put together the same package of files that plenty of other

board houses would have had no problem with.  Instead of boards, I got a

rather rude and terse email from Svetan about how the hole diameters

weren't metric, with the attitude that I was a jerk for wasting their time

with that.  No, I wasn't going to make one set of files for Olimex and one

for everyone else.  I found another board house that charged the same

(possibly even less if I recall correctly) and used the files as they were

without problem.  I never even mentioned Olimex to the customer.  This went

on to become a significant volume product.  I don't know where the customer

gets their boards today, but I know they started out with the same place I

used to get the prototype boards made.  They also used them for assembly

work later.

I don't know how much business Olimex has lost with their arrogant attitude

and the fact that their computers can't multiply by 25.4, but I know of

some for sure.

--

Web access to CadSoft support forums at www.eaglecentral.ca.  Where the CadSoft EAGLE community meets.

"Olin Lathrop" <eagle@embedinc.com> wrote in message

news:ho3ij6$fc8$1@cheetah.cadsoft.de...

maybe wrote on Sat, 20 March 2010 07:20

I am modifiying an ULP that adapts all drill sizes to Olimex ones

 

There are many board houses out there.  Why waste time with the only one

that can't multiply by 25.4....

Hey Olin not need to repeatedly slag them off. Taking your business

elsewhere is the correct course of action.

I have always assumed their restrictions were in place to streamline their

process and therefore offer cheaper prototype boards. I would imagine to

convert line thicknesses and drill sizes to make them suitable for their

process would also be simple and automatic post process but it gives them an

opportunity at add a couple of dollars to the bill. That's their business

model.

Many thanks for your tips but after many many trials have found the the

problem was not in that line, it was wrong of course, but in a previous

one.

I will keep onto learning ULP as this is my firs attempt to it.

Many Thanks Again Octavio

In article <200320101220123048%maybe@maybe.com>, maybe

<maybe@maybe.com> wrote:

I am modifiying an ULP that adapts all drill sizes to Olimex ones but

I want to check if the drill size is already and olimex standard.

 

So I want to check the value of "rval" against the standard values, so

have made that line ( formatting has been los a little )

 

but i get an error when running the ULP, have I made something wrong in

the

 

if.....

 

line

 

 

code fragment starts-------

 

real rval=isdrill// first we check if the drill value is an Olimex

standard, if so we do not modify it

 

if (rval!=3.3 || rval!=2.1 || rval!=1.5 || rval!=1.3 || rval!=1.1 ||

rval!=1.0 || rval!=0.9 || rval!=0.7) {

 

rval = round((isdrill+round_offset) * 10.0) / 10.0; // round value

 

}

 

 

 

 

code fragment end-------

 

Thanks in advance

Greg Erskine wrote on Sat, 20 March 2010 18:59

Hey Olin not need to repeatedly slag them off.

I guess that means you didn't get a rude email from Svetan for the horrible

crime of sending them files that didn't have metric hole diameters.

Quote:

Taking your business elsewhere is the correct course of action.

So is warning others.

--

Web access to CadSoft support forums at www.eaglecentral.ca.  Where the CadSoft EAGLE community meets.