Need Help with some Code

First this is needing to be changed

void ReadTimer(){
  DownCntr = map(analogRead(SetPot), 0, 1023, 5, 99);
  DownCntr*=10;

to

void ReadTimer(){
  DownCntr = map(analogRead(SetPot), 0, 1023, 10, 9999);
  DownCntr*=10;

and change this

void ShowTimer(){
  String minute = String (DownCntr, DEC);
  while(minute.length()<3)minute= "0" + minute;     //format to 3 numbers.
  mySerialPort.print(minute);                         //Write to Display.
  mySerialPort.print("0");                             //Last digit off.
}

to this

void ShowTimer(){
  String minute = String (DownCntr, DEC);
  while(minute.length()<4)minute= "0" + minute;     //format to 3 numbers.
  mySerialPort.print(minute);                         //Write to Display.
  mySerialPort.print("0");                             //Last digit off. <-- this line may need to be deleted
}

This should be enough from what I can see

The display in the diagram is not connected to the same pins as the code indicates

Hi, thanks for the reply.

I changed what you said to and when i upload to the arduino the display flickers random numbers

i also tried removing the line     mySerialPort.print("0");                             //Last digit off. <-- this line may need to be deleted

what happens if you only apply the first fix ?

I dont have your hardware so im trying to provide help through manual examination of the code ?

Peter

Random numbers scroll across the screen

just tested using the serial console as I dont have a LED display like the one you have

this works for the two functions (Thats all that needs changing)

/

/------------------------------------------------------
void ReadTimer(){
  DownCntr = map(analogRead(SetPot), 0, 1023, 10, 9999);
  //DownCntr*=10;
}
//------------------------------------------------------
void ShowTimer(){
  String minute = String (DownCntr, DEC);
  while(minute.length()<4)minute= "0" + minute;     //format to 4 numbers.
  mySerialPort.println(minute);                         //Write to Display.
  //mySerialPort.println("0");                             //Last digit off.
}

be aware though that you are up scaling the reading from the POT now so a count of 1023 will give you 9999 (10* the pot reading), you will not be able to adjust to exact time setting but it works aside from that

oh and you may well find the last 2 digits may ghange even though your not adjusting the pot, this is expected and normal due to the ADC reading slightly different each time and multiplying up the result

I have uploaded the new code and the display flicks between d010 & 10d0 

does the orgional code work ok and do you have the display connected and set to use serial rather than I2C or SPI ??, because that seems to make no sence, I ran you code with the exception of changing the myserial print statements to output to the normal serial port and it works just great

as in this (With my modes)

/*RocketLauncher

ROCKET LAUNCHER CONTROLLER.

Arduining.com  05 Jan 2012 (hardware implemented version)

-A count-down TIMER is implemented.

-The potentiometer is used to set the TIMER.

-Two Push-Buttons: "ARM" to set the counter and "GO" to start the counter.

-Display: Sparkfun's Serial 4 Digit 7-Segment Display . COM-09766 (RED).

-SoftwareSerial library is used to avoid random commands to the display

during program downloading.

*/

#define FuseTIME      1500  //Fuse current duration in milliminute.

//#include <SoftwareSerial.h>  //Usinf the SoftwareSerial library.

#define Fuss     7          //Pin connected to the Fuse relay.

#define GoButt   8          //Pin connected to the GO button.

#define ArmButt  9          //Pin connected to the ARM button.

#define BuzzPin  4          //Connected to the Speaker.

#define TXdata   3          //Conneted to Rx of the Display.

#define RXdata   2          //not used in this project

#define SetPot   0          //Analog Pin connected to the Pot.

//SoftwareSerial Serial(RXdata,TXdata);

void setup(){

  pinMode(TXdata,OUTPUT);

  pinMode(RXdata,INPUT);

  pinMode(Fuss,OUTPUT);

  pinMode(ArmButt, INPUT);        // set "ARM" button pin to input

  pinMode(GoButt, INPUT);         // set "GO" button pin to input

  digitalWrite(Fuss,LOW);         //OPEN the fuse circuit.

  digitalWrite(ArmButt, HIGH);    // turn on pullup resistor

  digitalWrite(GoButt, HIGH);     // turn on pullup resistor

  Serial.begin(9600);

  delay(10);                      //Wait for Serial Display startup.

  Serial.print("v");        //Reset the display.

  Serial.print("z");        //Brightness Control.

  Serial.write(0x40);       //3/4 Intensity.

Serial.println();

}

int  DownCntr;                    // down counter (1/10 Secs.)

int  Go=0;                        // Stopped

//================================================================

void loop(){

  if(!digitalRead(GoButt)||!digitalRead(ArmButt)){

    Go=0;                         //ABORT!!!

    tone(BuzzPin, 440, 1500);

    delay(1500);

  }

  if(Go==0){

    WaitARM();

    WaitGO();

  }

  ShowTimer();

  if (DownCntr > 50){

      if (DownCntr % 10 ==0)tone(BuzzPin, 1000, 50);  //Tone every second.

     }

  else if (DownCntr % 2 ==0)tone(BuzzPin, 1000, 50);  //Tone every 1/5 second.

  if (DownCntr ==0){

    //------------------ ROCKET LAUNCH! --------------------

    tone(BuzzPin, 440, FuseTIME);  //Launch audible signal

    digitalWrite(Fuss,HIGH);       //CLOSE the fuse circuit

    delay(FuseTIME);

    delay(FuseTIME);

    delay(FuseTIME);

    delay(FuseTIME);

    digitalWrite(Fuss,LOW);        //OPEN the fuse circuit.

    //------------------------------------------------------

     Go=0;

    }

  while (millis()% 100);        //Wait until the next 1/10 of second.

  delay(50);

  DownCntr--;

}

//----------------------------------------

void WaitGO(){

  ShowTimer();

  while(digitalRead(GoButt));

  Go=1;

  delay(20);

  while(!digitalRead(GoButt));  //Debounce GO button.

}

//------------------------------------------------------

void ReadTimer(){

  DownCntr = map(analogRead(SetPot), 0, 1023, 10, 9999);

  //DownCntr*=10;

}

//------------------------------------------------------

void ShowTimer(){

  String minute = String (DownCntr, DEC);

  while(minute.length()<4)minute= "0" + minute;     //format to 3 numbers.

  Serial.println(minute);                         //Write to Display.

  //Serial.println("0");                             //Last digit off.

}

//------------------------------------------------------

void WaitARM(){

  while(digitalRead(ArmButt)==1){

     ReadTimer();

     delay(50);

     ReadTimer();

     ShowTimer();                   //Show Digits.

     delay(150);

  }

  Go=0;

  ShowTimer();

  tone(BuzzPin, 2000, 150);

  delay(200);

  tone(BuzzPin, 2000, 150);

  delay(200);

  tone(BuzzPin, 2000, 150);

  delay(20);

  while(!digitalRead(ArmButt));  //Debounce ARM button.

}

The original code set to 5-99s with 3 digits works and yes the display is setup using serial UART

try the program i posted and see if it displays correctly over the serial port of the PC IDE serial console ? and let me know the result

Thanks

Hi, it works in the serial monitor on the pc