Actions
Forum Thread Details
  • Replies 15 replies
  • Subscribers 365 subscribers
  • Views 2140 views
  • Users 0 members are here
Related

Coding with else{}...what are the cost benefits analysis?

colporteur 

if (digitalRead(ButtonPin) == LOW) {  //}

OR

if (digitalRead(ButtonPin) == HIGH) {  //
  return HIGH;
} else {  //}

I came across these two methods of testing a button. They both accomplish the same thing. 

Why would a coder use one over the other? What are advantages/disadvantages to using either?

I am a code resurrectionist not a programmer or coder. I usually cut and paste code parts to develop a working project. I have code that use both methods. I'm curious what falls into best practice? Does one provide better performance?

Parents

  • I came across a situation today which is essentially the reverse of what you have found: a ‘hanging’ if:

    if (aTestForTrue) [
   // do nothing
else {
   some code;
   some more code;
   ...
}

    I’ve seen this quite a few times and used it myself a few times, including today.  It’s done this way because the logic test is much clearer to write and understand than it’s inverse would be, and it’s a nod to the future where someone would have to maintain it.  It looks weird, and some purists and/or corporate standards would argue against it;  also, it’s unlikely the compiler would optimise his out as it isn’t as simple a case as the ‘hanging else’ would be.  But the code is more readable, speed of execution isn’t critical and the author (me) knows what they are doing!!

Reply

  • I came across a situation today which is essentially the reverse of what you have found: a ‘hanging’ if:

    if (aTestForTrue) [
   // do nothing
else {
   some code;
   some more code;
   ...
}

    I’ve seen this quite a few times and used it myself a few times, including today.  It’s done this way because the logic test is much clearer to write and understand than it’s inverse would be, and it’s a nod to the future where someone would have to maintain it.  It looks weird, and some purists and/or corporate standards would argue against it;  also, it’s unlikely the compiler would optimise his out as it isn’t as simple a case as the ‘hanging else’ would be.  But the code is more readable, speed of execution isn’t critical and the author (me) knows what they are doing!!

Children
No Data