Saving BOM

Hi Matt,

Not sure if you've already sorted this out yet. Thanks for opening the thread, glad other people had the same issue. I feel a little less silly spending some time figuring this out but I think I found a fix!

Edit: looks like my fix below messes up the part grouping. The sort by values is needed for they way the example bom.ulp finds identical parts to group onto the same line.

However, looks like this place has solved the issue by redoing the way the ulp finds identical parts AND sorts them by designator!

http://www.pcserviceselectronics.co.uk/eagleulp/

---------------------------------

1. Digging into the BOM.ULP, there's a sort( ) function line that needs to be modified so it sorts on PartName first instead of PartValue

here's a snippet from my customized BOM_custom.ulp

void GenerateValueList (void)
{
  int NumLines = 0;
  int Index [];
  string attr[], s, s_val;

  if (UseAttributes) s = strjoin(AttributesList, '\t');

  // 2010-04-17 cwi: Included description.
  // JPL: moved "Parts" designator adjacent to Qty (column headers here)
  Lines[NumLines ++] = tr ("Qty\tParts\tValue\tDevice\tPackage\tDescription\t") + s;                 // 2011-04-08
  //sort (NumParts, Index, PartValue, PartDevice, PartPackage, PartAttributes, PartName, PartHeadline); // 2011-11-08 Partattribute jetzt nach Package alf@cadsoft.de
  sort (NumParts, Index, PartName, PartValue, PartDevice, PartPackage, PartAttributes, PartHeadline); // 2011-11-08 Partattribute jetzt nach Package alf@cadsoft.de...JPL: moved PartName after Index to sort by PartName first!
  for (int n1 = 0, n2 = 0; ++ n2 <= NumParts; )
  {
    int i1 = Index [n1];
    strsplit (attr, PartAttributes[i1], Separator);
    if (UseAttributes) s = strjoin(attr, '\t');
    s_val = attr[i1];
    if (n2 < NumParts)
    {
      int i2 = Index [n2]; // 2012-11-08
      strsplit (attr, PartAttributes[i2], Separator);
      if (PartValue[i1] == PartValue[i2] && PartDevice[i1] == PartDevice[i2] && PartAttributes[i1] == PartAttributes[i2]) // 2012-11-08 check diffent values of attributes
        continue;
    }
    string Quantity;
    sprintf (Quantity, "%d", n2 - n1);
    // JPL: moved "Parts" designator adjacent to Qty
    //Lines[NumLines] = Quantity + "\t" + PartValue[i1] + "\t" + PartDevice[i1] + "\t" + PartPackage[i1] + "\t";
    Lines[NumLines] = Quantity + "\t"; // + "\t" + PartValue[i1] + "\t" + PartDevice[i1] + "\t" + PartPackage[i1] + "\t";
    for (;;)
    {
      Lines[NumLines] += PartName[i1];
      if (++n1 < n2)
      {
        i1 = Index [n1];
        Lines[NumLines] += ", ";
      }
      else
        break;
    }
    // JPL: moved "Parts" designator adjacent to Qty, others needed shifted right (i.e. after the parts designator 'for' loop).
    Lines[NumLines] += "\t" + PartValue[i1] + "\t" + PartDevice[i1] + "\t" + PartPackage[i1];
    // cwi: add extra information from attributes
    // 2010-04-17 cwi: Included description.
    Lines[NumLines] += "\t" + PartHeadline[i1] + "\t" + s;
    NumLines ++;
  }
  Lines[NumLines] = "";
}

Comparing commented out line 12 with line 13: I moved PartName just after Index. If you read the documentation on sort( ), NumParts is just an integer, Index is an empty array, and the first array after Index is the first one to be sorted. However, the sort( ) documentation is pretty thin and doesn't describe the behavior of how you order the arrays within the function call.

The sort( ) function was a little hard to decipher but some trial and error this looks like it works!

Essentially the internal list generated by the ULP isn't affected at all by the dialog box, the ULP just prints to the dialog box but the internal list is separate, and when you hit Save it just takes the internal list "Lines[ ]" and dumps it into the csv.

2. I liked how some other BOMs had the PartName/Designator right next to the quantity, here is the fix for that. It's a little more involved but it seems to work. Same code spinnet as above, see line callouts

Line 11 is only for the column headers

Line 30: break up the list and move some column data insertions to after the for( ) loop

Line 44: insert back in the columns from line 30, be mindful of the + "\t" so you don't accidentally have one too many. The code is all setup for tab-delimited then changes to commas at the save-to-csv.

It looks like it was out of convenience that they put the PartNames after PartPackage since PartNames requires a for( ) loop to search through and find duplicates and group them together.

To fix that, you need to break up the first group of columns, leaving only Quatity, then do the for( ) loop, then bring back in the rest of the columns.

Hi Matt,

Not sure if you've already sorted this out yet. Thanks for opening the thread, glad other people had the same issue. I feel a little less silly spending some time figuring this out but I think I found a fix!

Edit: looks like my fix below messes up the part grouping. The sort by values is needed for they way the example bom.ulp finds identical parts to group onto the same line.

However, looks like this place has solved the issue by redoing the way the ulp finds identical parts AND sorts them by designator!

http://www.pcserviceselectronics.co.uk/eagleulp/

---------------------------------

1. Digging into the BOM.ULP, there's a sort( ) function line that needs to be modified so it sorts on PartName first instead of PartValue

here's a snippet from my customized BOM_custom.ulp

void GenerateValueList (void)
{
  int NumLines = 0;
  int Index [];
  string attr[], s, s_val;

  if (UseAttributes) s = strjoin(AttributesList, '\t');

  // 2010-04-17 cwi: Included description.
  // JPL: moved "Parts" designator adjacent to Qty (column headers here)
  Lines[NumLines ++] = tr ("Qty\tParts\tValue\tDevice\tPackage\tDescription\t") + s;                 // 2011-04-08
  //sort (NumParts, Index, PartValue, PartDevice, PartPackage, PartAttributes, PartName, PartHeadline); // 2011-11-08 Partattribute jetzt nach Package alf@cadsoft.de
  sort (NumParts, Index, PartName, PartValue, PartDevice, PartPackage, PartAttributes, PartHeadline); // 2011-11-08 Partattribute jetzt nach Package alf@cadsoft.de...JPL: moved PartName after Index to sort by PartName first!
  for (int n1 = 0, n2 = 0; ++ n2 <= NumParts; )
  {
    int i1 = Index [n1];
    strsplit (attr, PartAttributes[i1], Separator);
    if (UseAttributes) s = strjoin(attr, '\t');
    s_val = attr[i1];
    if (n2 < NumParts)
    {
      int i2 = Index [n2]; // 2012-11-08
      strsplit (attr, PartAttributes[i2], Separator);
      if (PartValue[i1] == PartValue[i2] && PartDevice[i1] == PartDevice[i2] && PartAttributes[i1] == PartAttributes[i2]) // 2012-11-08 check diffent values of attributes
        continue;
    }
    string Quantity;
    sprintf (Quantity, "%d", n2 - n1);
    // JPL: moved "Parts" designator adjacent to Qty
    //Lines[NumLines] = Quantity + "\t" + PartValue[i1] + "\t" + PartDevice[i1] + "\t" + PartPackage[i1] + "\t";
    Lines[NumLines] = Quantity + "\t"; // + "\t" + PartValue[i1] + "\t" + PartDevice[i1] + "\t" + PartPackage[i1] + "\t";
    for (;;)
    {
      Lines[NumLines] += PartName[i1];
      if (++n1 < n2)
      {
        i1 = Index [n1];
        Lines[NumLines] += ", ";
      }
      else
        break;
    }
    // JPL: moved "Parts" designator adjacent to Qty, others needed shifted right (i.e. after the parts designator 'for' loop).
    Lines[NumLines] += "\t" + PartValue[i1] + "\t" + PartDevice[i1] + "\t" + PartPackage[i1];
    // cwi: add extra information from attributes
    // 2010-04-17 cwi: Included description.
    Lines[NumLines] += "\t" + PartHeadline[i1] + "\t" + s;
    NumLines ++;
  }
  Lines[NumLines] = "";
}

Comparing commented out line 12 with line 13: I moved PartName just after Index. If you read the documentation on sort( ), NumParts is just an integer, Index is an empty array, and the first array after Index is the first one to be sorted. However, the sort( ) documentation is pretty thin and doesn't describe the behavior of how you order the arrays within the function call.

The sort( ) function was a little hard to decipher but some trial and error this looks like it works!

Essentially the internal list generated by the ULP isn't affected at all by the dialog box, the ULP just prints to the dialog box but the internal list is separate, and when you hit Save it just takes the internal list "Lines[ ]" and dumps it into the csv.

2. I liked how some other BOMs had the PartName/Designator right next to the quantity, here is the fix for that. It's a little more involved but it seems to work. Same code spinnet as above, see line callouts

Line 11 is only for the column headers

Line 30: break up the list and move some column data insertions to after the for( ) loop

Line 44: insert back in the columns from line 30, be mindful of the + "\t" so you don't accidentally have one too many. The code is all setup for tab-delimited then changes to commas at the save-to-csv.

It looks like it was out of convenience that they put the PartNames after PartPackage since PartNames requires a for( ) loop to search through and find duplicates and group them together.

To fix that, you need to break up the first group of columns, leaving only Quatity, then do the for( ) loop, then bring back in the rest of the columns.