Actions
Forum Thread Details
  • Replies 2 replies
  • Subscribers 559 subscribers
  • Views 1859 views
  • Users 0 members are here
Related

Help with Petalinux device tree config

mesamike

I am using Petalinux 2019.2 with a Picozed.

I want to add a CAN device node.
I follow UG1144 for adding a block to the device tree to describe the CAN PS device, but when I rebuild, the build fails, complaining about a syntax error in my can-conf.dtsi file (which is where I put the CAN device block).

Here is my block:

&zynq_can_0: can@e0008000 {

        compatible = "xlnx,zynq-can-1.0";

        clocks = <&clkc 19>, <&clkc 36>;

        clock-names = "can_clk", "pclk";

        reg = <0xe0008000 0x1000>;

        interrupts = <0 28 4>;

        interrupt-parent = <&intc>;

        tx-fifo-depth = <0x40>;

        rx-fifo-depth = <0x40>;

};



The error message indicates the syntax error is on the first line, but I don't see what's wrong.

I wonder if anybody has had success with this, or can spot what I may be doing wrong.

Thanks





  • Hi there,

     

    Do you have an editor that highlights braces?  I know back when we had to add all that stuff by hand for SDSoC, most of the time when I would goof, it was a } in the wrong spot.  That is, I put my block inside another block.

    I hope it is that simple!  I will also pass this along to one of our PetaLinux experts and see what they can see.

    Also, can you paste a new copy of the code, and put it inside a "Syntax Highlight" block?  plain should be OK.  I am just curious about and possible "hidden" text issues.

     

    --Dan

  • in reply to drozwood90

    Thanks for your response.

    I found that it seems that there is an outer wrapping that I needed on what I wrote above, at it should look like this:


    &can0 {

       zynq_can_0: can@e0008000 {

            compatible = "xlnx,zynq-can-1.0";

            clocks = <&clkc 19>, <&clkc 36>;

            clock-names = "can_clk", "pclk";

            reg = <0xe0008000 0x1000>;

            interrupts = <0 28 4>;

            interrupt-parent = <&intc>;

            tx-fifo-depth = <0x40>;

            rx-fifo-depth = <0x40>;

       };

    };


    Available documentation on the format of the device tree file seems to be lacking detail / contradictory.

    This section is not inside any other set of braces, in fact it is the entire file can-conf.dtsi which I include in system-user.dtsi
    The project builds now without error...

    However, when I boot the new image, I don't get a device node under /dev for my CAN device, so...  something else needs to be done apparently.