DIY Shapeoko CNC Pendant -- Episode 420

I have made the project and can confirm that the original code runs just fine.

The behavior you described is how it is intended to function, as you can see from the code:

When pressing one of the speed buttons, the activespeed variable is being changed.

  if (buttonFast.fallingEdge()) {

    activeSpeed = SPD_FAST;

  }

The next time the loop() executes, the if statement triggers and presses a key (KEY_4)

if (activeSpeed != lastSpeed){

    digitalWrite(lastSpeedLED, LOW);

    switch(activeSpeed){

      case SPD_FAST:

        Keyboard.press(KEY_4);

        Keyboard.release(KEY_4);

        digitalWrite(PIN_LED_FAST, HIGH);

        lastSpeedLED = PIN_LED_FAST;

      break;

When pressing one of the X, Y, Z buttons, the activeAxis variable is being changed.

(uncomment the serial print to verify if your button works)

  if (buttonX.fallingEdge()) {

    activeAxis = X_AXIS;

    //Serial.println("X");

  }

HOWEVER, the corresponding button (KEY_RIGHT) is ONLY being pressed when the encoder is turned.
Pressing the X, Y or Z button only will NOT press any keyboard key.

  if (abs(newScrollPos - lastScrollPos) >= 4) { // there are roughly four presses detected from each rotation to the next detent

    if (newScrollPos - lastScrollPos > -1){ // positive increase

      switch(activeAxis){

      case X_AXIS:

        Keyboard.press(KEY_RIGHT);

        Keyboard.release(KEY_RIGHT);

      break;

In conclusion: if your CNC doesn't move, your rotary encoder is probably badly connected.

Check the connections from encoder to teensy (also the middle ground pin). If that fails, I would buy a new encoder and try again.

Hope this helped

Thomas

Hello Thomas, thank you so much for helping me out with this, it's driving me nuts.   I bought 2 encoders, so I'll try changing them out today.  I checked the impedance on the encoder, and it changed as I rotated it, so I assumed it was working.  I used the three sided pins of the encoder, outer pin goes to pin 9 on the controller, the center pin is to ground, and the other outer pin is connected to pin 10 on the controller.   I opened the serial monitor and uncommitted the serial print line and each time I press the X,Y,X buttons it shows on the output of the serial monitor screen.  Should it repeat the X,Y,Z on the screen if I turn the encoder?   I'm still learning how to program, so this is way above my understanding.  Is there any way to see if the controller is actually sending the commands, like KEY_RIGHT?  I really need to get this working, so I really appreciate your help.  I just can't figure out what I'm doing wrong.  I have tried it on Easel, and Universal Gcode Sender, and my CNC doesn't move, but it moves if I use the up,down,left,right on my keyboard.

Alright, good that we know the key pressing parts is working.

I meant a picture of the connections to the Teensy, to see how you soldered it.

Normally the encoder middle pin should be connected to ground, since the microcontroller has pullups enabled.

Look OK?

Wiring looks good too.

Try adding a println here:

long newScrollPos = encoderScroll.read();

Serial.println(newScrollPos );

The number should increase every time you turn the encoder.

As an additional check, also add these lines (will trigger if the encoder gives a pulse):

if (digitalRead(PIN_ENC_A) == LOW){

    Serial.println("ENC A TRIGGERED");

  }

You can also try soldering it to 2 other pins.

Change the used pin numbers in the code:

#define PIN_ENC_A     9

#define PIN_ENC_B     10

And add these two lines in setup:

void setup() {

     pinMode(PIN_ENC_A, INPUT_PULLUP);

     pinMode(PIN_ENC_B, INPUT_PULLUP);

     ...

}

As a last suggestion for today:

The code should also work jf you add a switch between pin 9 and ground or pin 10 and ground. This should give the same result as using an encoder (but less practical of course). By trying this we can rule out a faulty encoder.

Interesting.  I included this in the program

long newScrollPos = encoderScroll.read();

  Serial.println(newScrollPos );

  if (digitalRead(PIN_ENC_A) == LOW){

Serial.println("ENC A TRIGGERED");

if (digitalRead(PIN_ENC_B) == HIGH){

Serial.println("ENC B TRIGGERED");

Here are the results.  when I'm not turning thr encoder, it keeps putting out 00000000000000

And I included this where it should be outputting the left, right, up, down

Serial.println("NEW_NEW");

but "NEW_NEW" never showed up in the serial monitor.  For some reason, it's not going past this line

if (abs(newScrollPos - lastScrollPos) >= 4) { // there are roughly four presses detected from each rotation to the next detent

    if (newScrollPos - lastScrollPos > -1){ // positive increase

      switch(activeAxis){

Any more ideas??  Thanks Dave...........

I changed to pins 22 and 23, but get the same results as before.

I don't see a change when I ground pins 9 and 10 to ground.  I see the change if I turn the encoder, but not by grounding the pins??

So the number never changes from 0 to 1 or higher?

Try to connect two buttons instead of the rotary encoder and check the output of this code again:

1 button between pin 9 and ground, 1 button between pin 10 and ground.

long newScrollPos = encoderScroll.read();

  Serial.println(newScrollPos );

Do you have a part number of that rotary encoder?

I am suspecting that you are not using an encoder, but a potentiometer (variable resistor).

Can you turn the shaft more than 360 degrees or does it have limits? A rotary encoder should be able to continously turn.

Hi Thomas, any other ideas?   to me it looks like for some reason the program is never getting to this part:  I tried understanding the logic, but it's way above my head.

long newScrollPos = encoderScroll.read();

  if (abs(newScrollPos - lastScrollPos) >= 4) { // there are roughly four presses detected from each rotation to the next detent

    if (newScrollPos - lastScrollPos > -1){ // positive increase

      switch(activeAxis){

      case X_AXISr:

        Keyboard.press(KEY_RIGHT);

        Keyboard.release(KEY_RIGHT);

      break;

      case Y_AXISr:

        Keyboard.press(KEY_UP);

        Keyboard.release(KEY_UP);

      break;

      case Z_AXISr:

        Keyboard.press(KEY_PAGE_UP);

        Keyboard.release(KEY_PAGE_UP);

      }

    } else {

      switch(activeAxis){

      case X_AXISr:

        Keyboard.press(KEY_LEFT);

        Keyboard.release(KEY_LEFT);

      break;

      case Y_AXISr:

        Keyboard.press(KEY_DOWN);

        Keyboard.release(KEY_DOWN);

      break;

      case Z_AXISr:

        Keyboard.press(KEY_PAGE_DOWN);

        Keyboard.release(KEY_PAGE_DOWN);

      }

    }

    lastScrollPos = newScrollPos;

  }

  if (activeAxis != lastAxis){

    digitalWrite(lastAxisLED, LOW);

    switch(activeAxis){

      case X_AXISr:

        digitalWrite(PIN_LED_X, HIGH);

        lastAxisLED = PIN_LED_X;

      break;

      case Y_AXISr:

        digitalWrite(PIN_LED_Y, HIGH);

        lastAxisLED = PIN_LED_Y;

      break;

      case Z_AXISr:

        digitalWrite(PIN_LED_Z, HIGH);

        lastAxisLED = PIN_LED_Z;

      break;

    }

    lastAxis = activeAxis;

  }

  if (activeSpeed != lastSpeed){

    digitalWrite(lastSpeedLED, LOW);

    switch(activeSpeed){

      case SPD_FAST:

        Keyboard.press(KEY_4);

        Keyboard.release(KEY_4);

        digitalWrite(PIN_LED_FAST, HIGH);

        lastSpeedLED = PIN_LED_FAST;

      break;

      case SPD_1MM:

        Keyboard.press(KEY_3);

        Keyboard.release(KEY_3);

        digitalWrite(PIN_LED_1MM, HIGH);

        lastSpeedLED = PIN_LED_1MM;

      break;

      case SPD_01MM:

        Keyboard.press(KEY_2);

        Keyboard.release(KEY_2);

        digitalWrite(PIN_LED_01MM, HIGH);

        lastSpeedLED = PIN_LED_01MM;

      break;

      case SPD_001MM:

        Keyboard.press(KEY_1);

        Keyboard.release(KEY_1);

        digitalWrite(PIN_LED_001MM, HIGH);

        lastSpeedLED = PIN_LED_001MM;

      break;

    }

    lastSpeed = activeSpeed;

Hi Thomas, any other ideas?   to me it looks like for some reason the program is never getting to this part:  I tried understanding the logic, but it's way above my head.

long newScrollPos = encoderScroll.read();

  if (abs(newScrollPos - lastScrollPos) >= 4) { // there are roughly four presses detected from each rotation to the next detent

    if (newScrollPos - lastScrollPos > -1){ // positive increase

      switch(activeAxis){

      case X_AXISr:

        Keyboard.press(KEY_RIGHT);

        Keyboard.release(KEY_RIGHT);

      break;

      case Y_AXISr:

        Keyboard.press(KEY_UP);

        Keyboard.release(KEY_UP);

      break;

      case Z_AXISr:

        Keyboard.press(KEY_PAGE_UP);

        Keyboard.release(KEY_PAGE_UP);

      }

    } else {

      switch(activeAxis){

      case X_AXISr:

        Keyboard.press(KEY_LEFT);

        Keyboard.release(KEY_LEFT);

      break;

      case Y_AXISr:

        Keyboard.press(KEY_DOWN);

        Keyboard.release(KEY_DOWN);

      break;

      case Z_AXISr:

        Keyboard.press(KEY_PAGE_DOWN);

        Keyboard.release(KEY_PAGE_DOWN);

      }

    }

    lastScrollPos = newScrollPos;

  }

  if (activeAxis != lastAxis){

    digitalWrite(lastAxisLED, LOW);

    switch(activeAxis){

      case X_AXISr:

        digitalWrite(PIN_LED_X, HIGH);

        lastAxisLED = PIN_LED_X;

      break;

      case Y_AXISr:

        digitalWrite(PIN_LED_Y, HIGH);

        lastAxisLED = PIN_LED_Y;

      break;

      case Z_AXISr:

        digitalWrite(PIN_LED_Z, HIGH);

        lastAxisLED = PIN_LED_Z;

      break;

    }

    lastAxis = activeAxis;

  }

  if (activeSpeed != lastSpeed){

    digitalWrite(lastSpeedLED, LOW);

    switch(activeSpeed){

      case SPD_FAST:

        Keyboard.press(KEY_4);

        Keyboard.release(KEY_4);

        digitalWrite(PIN_LED_FAST, HIGH);

        lastSpeedLED = PIN_LED_FAST;

      break;

      case SPD_1MM:

        Keyboard.press(KEY_3);

        Keyboard.release(KEY_3);

        digitalWrite(PIN_LED_1MM, HIGH);

        lastSpeedLED = PIN_LED_1MM;

      break;

      case SPD_01MM:

        Keyboard.press(KEY_2);

        Keyboard.release(KEY_2);

        digitalWrite(PIN_LED_01MM, HIGH);

        lastSpeedLED = PIN_LED_01MM;

      break;

      case SPD_001MM:

        Keyboard.press(KEY_1);

        Keyboard.release(KEY_1);

        digitalWrite(PIN_LED_001MM, HIGH);

        lastSpeedLED = PIN_LED_001MM;

      break;

    }

    lastSpeed = activeSpeed;

See my previous post:

So the number never changes from 0 to 1 or higher?

Try to connect two buttons instead of the rotary encoder and check the output of this code again:

1 button between pin 9 and ground, 1 button between pin 10 and ground.

long newScrollPos = encoderScroll.read();

  Serial.println(newScrollPos );

Do you have a part number of that rotary encoder?

I am suspecting that you are not using an encoder, but a potentiometer (variable resistor).

Can you turn the shaft more than 360 degrees or does it have limits? A rotary encoder should be able to continously turn.

• Helpful Yes | NoLike (0)Reply
• Actions

OK, connected the two buttons and add the code.  It sends out a continuous series of zeros to the right.  Nothing changes if I ground pins 9 or 10.  I used the same encoder as the one in the project from Element14  Attached are the specs.

Just seems like it's not reaching the keyboard commands.  It's a brand new teensy, but I guess it could be bad, but even changing the pin assignments I get the same results.  In the program, should the  //Serial.begin(9600);  not be commented out?  I did change it, but got the same results.   ???

for (int ii = 2; ii < 11; ii++) pinMode(ii, INPUT_PULLUP);

  for (int ii = 14; ii < 21; ii++) pinMode(ii, OUTPUT);

  digitalWrite(PIN_LED_X, HIGH);

  digitalWrite(PIN_LED_FAST, HIGH);

  //Serial.begin(9600);

The Serial.begin(9600); is needed for the serial monitor, just leave it uncommented.

Since nor the buttons, nor the encoder trigger the encoderScroll.read(); function, I suspect you might be using the wrong library.

This is the one I am using: https://github.com/PaulStoffregen/Encoder

Normally, Arduino stores the libraries under Document/libraries/

Remove all existing encoder libraries from this folder (if any) and replace with the one from the link above.

Nope, still no change??

I'm running out of ideas...

Include those lines and upload of picture of the serial monitor when turning the encoder:

  if (digitalRead(PIN_ENC_A) == LOW){

     Serial.println("ENC A LOW TRIGGERED");
  }

  if (digitalRead(PIN_ENC_A) == HIGH){

     Serial.println("ENC A HIGH TRIGGERED");
  }

  if (digitalRead(PIN_ENC_B) == LOW){

     Serial.println("ENC B LOW TRIGGERED");
  }

  if (digitalRead(PIN_ENC_B) == HIGH){

     Serial.println("ENC B HIGH TRIGGERED");
  }

Also, in File>Preferences, enable these settings:

Share a screenshot of the output.

Don't give up on me LOL

OK, I put the text after this:

long newScrollPos = encoderScroll.read();

I don't see what checking the two boxes did?

Here are the screen shots, it changed based on turning the encoder.  But, it was always printing something even when I wasn't pushing a button or turning the encoder??

Hi Thomas, could the pin configuration between the Teensy 3.2 and LC cause the issue?

When did you get the

"ENC A HIGH TRIGGERED" and
"ENC B HIGH TRIGGERED" ?

If that happens when the encoder is turned, the encoder is connected correctly.

In that case, the problem lies with the encoder library.

I would like to see the output of this window when compiling and uploading. All of it

Don't think so, I already checked the differences and none are major dealbreakers.

Hi Thomas, I can't figure out how to copy and paste that data, is there a trick to it?  Dave........................