DIY Shapeoko CNC Pendant -- Episode 420

See my previous post:

So the number never changes from 0 to 1 or higher?

Try to connect two buttons instead of the rotary encoder and check the output of this code again:

1 button between pin 9 and ground, 1 button between pin 10 and ground.

long newScrollPos = encoderScroll.read();

  Serial.println(newScrollPos );

Do you have a part number of that rotary encoder?

I am suspecting that you are not using an encoder, but a potentiometer (variable resistor).

Can you turn the shaft more than 360 degrees or does it have limits? A rotary encoder should be able to continously turn.

• Helpful Yes | NoLike (0)Reply
• Actions

Hi Thomas, any other ideas?   to me it looks like for some reason the program is never getting to this part:  I tried understanding the logic, but it's way above my head.

long newScrollPos = encoderScroll.read();

  if (abs(newScrollPos - lastScrollPos) >= 4) { // there are roughly four presses detected from each rotation to the next detent

    if (newScrollPos - lastScrollPos > -1){ // positive increase

      switch(activeAxis){

      case X_AXISr:

        Keyboard.press(KEY_RIGHT);

        Keyboard.release(KEY_RIGHT);

      break;

      case Y_AXISr:

        Keyboard.press(KEY_UP);

        Keyboard.release(KEY_UP);

      break;

      case Z_AXISr:

        Keyboard.press(KEY_PAGE_UP);

        Keyboard.release(KEY_PAGE_UP);

      }

    } else {

      switch(activeAxis){

      case X_AXISr:

        Keyboard.press(KEY_LEFT);

        Keyboard.release(KEY_LEFT);

      break;

      case Y_AXISr:

        Keyboard.press(KEY_DOWN);

        Keyboard.release(KEY_DOWN);

      break;

      case Z_AXISr:

        Keyboard.press(KEY_PAGE_DOWN);

        Keyboard.release(KEY_PAGE_DOWN);

      }

    }

    lastScrollPos = newScrollPos;

  }

  if (activeAxis != lastAxis){

    digitalWrite(lastAxisLED, LOW);

    switch(activeAxis){

      case X_AXISr:

        digitalWrite(PIN_LED_X, HIGH);

        lastAxisLED = PIN_LED_X;

      break;

      case Y_AXISr:

        digitalWrite(PIN_LED_Y, HIGH);

        lastAxisLED = PIN_LED_Y;

      break;

      case Z_AXISr:

        digitalWrite(PIN_LED_Z, HIGH);

        lastAxisLED = PIN_LED_Z;

      break;

    }

    lastAxis = activeAxis;

  }

  if (activeSpeed != lastSpeed){

    digitalWrite(lastSpeedLED, LOW);

    switch(activeSpeed){

      case SPD_FAST:

        Keyboard.press(KEY_4);

        Keyboard.release(KEY_4);

        digitalWrite(PIN_LED_FAST, HIGH);

        lastSpeedLED = PIN_LED_FAST;

      break;

      case SPD_1MM:

        Keyboard.press(KEY_3);

        Keyboard.release(KEY_3);

        digitalWrite(PIN_LED_1MM, HIGH);

        lastSpeedLED = PIN_LED_1MM;

      break;

      case SPD_01MM:

        Keyboard.press(KEY_2);

        Keyboard.release(KEY_2);

        digitalWrite(PIN_LED_01MM, HIGH);

        lastSpeedLED = PIN_LED_01MM;

      break;

      case SPD_001MM:

        Keyboard.press(KEY_1);

        Keyboard.release(KEY_1);

        digitalWrite(PIN_LED_001MM, HIGH);

        lastSpeedLED = PIN_LED_001MM;

      break;

    }

    lastSpeed = activeSpeed;

So the number never changes from 0 to 1 or higher?

Try to connect two buttons instead of the rotary encoder and check the output of this code again:

1 button between pin 9 and ground, 1 button between pin 10 and ground.

long newScrollPos = encoderScroll.read();

  Serial.println(newScrollPos );

Do you have a part number of that rotary encoder?

I am suspecting that you are not using an encoder, but a potentiometer (variable resistor).

Can you turn the shaft more than 360 degrees or does it have limits? A rotary encoder should be able to continously turn.

I don't see a change when I ground pins 9 and 10 to ground.  I see the change if I turn the encoder, but not by grounding the pins??

I changed to pins 22 and 23, but get the same results as before.

Interesting.  I included this in the program

long newScrollPos = encoderScroll.read();

  Serial.println(newScrollPos );

  if (digitalRead(PIN_ENC_A) == LOW){

Serial.println("ENC A TRIGGERED");

if (digitalRead(PIN_ENC_B) == HIGH){

Serial.println("ENC B TRIGGERED");

Here are the results.  when I'm not turning thr encoder, it keeps putting out 00000000000000

And I included this where it should be outputting the left, right, up, down

Serial.println("NEW_NEW");

but "NEW_NEW" never showed up in the serial monitor.  For some reason, it's not going past this line

if (abs(newScrollPos - lastScrollPos) >= 4) { // there are roughly four presses detected from each rotation to the next detent

    if (newScrollPos - lastScrollPos > -1){ // positive increase

      switch(activeAxis){

Any more ideas??  Thanks Dave...........

As a last suggestion for today:

The code should also work jf you add a switch between pin 9 and ground or pin 10 and ground. This should give the same result as using an encoder (but less practical of course). By trying this we can rule out a faulty encoder.

You can also try soldering it to 2 other pins.

Change the used pin numbers in the code:

#define PIN_ENC_A     9

#define PIN_ENC_B     10

And add these two lines in setup:

void setup() {

     pinMode(PIN_ENC_A, INPUT_PULLUP);

     pinMode(PIN_ENC_B, INPUT_PULLUP);

     ...

}

Wiring looks good too.

Try adding a println here:

long newScrollPos = encoderScroll.read();

Serial.println(newScrollPos );

The number should increase every time you turn the encoder.

As an additional check, also add these lines (will trigger if the encoder gives a pulse):

if (digitalRead(PIN_ENC_A) == LOW){

    Serial.println("ENC A TRIGGERED");

  }

Look OK?